Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebProfilerBundle] Custom categories generate too many elements in the timeline legend #33536

Closed
javiereguiluz opened this issue Sep 10, 2019 · 0 comments
Closed

[WebProfilerBundle] Custom categories generate too many elements in the timeline legend #33536

javiereguiluz opened this issue Sep 10, 2019 · 0 comments
Labels
Bug Status: Needs Review WebProfilerBundle
Milestone
3.4

Comments

@javiereguiluz
Copy link
Member

Symfony version(s) affected: all

Description
While working on #33535 I realized that the buttons for the custom Stopwatch categories are generated five times (although only one is visible):

image

This issue was present before working on #33535, so it's completely unrelated.

How to reproduce
Profile any Symfony app and add at least one custom Stopwatch section.
@javiereguiluz javiereguiluz added this to the 3.4 milestone Sep 10, 2019
@fancyweb fancyweb mentioned this issue Sep 13, 2019
Merged
@fabpot fabpot closed this as completed Sep 15, 2019
fabpot added a commit that referenced this issue Sep 15, 2019
@fabpot
bug #33575 [WebProfilerBundle] Fix time panel legend buttons (fancyweb)
1a9c633 
This PR was merged into the 4.3 branch.

Discussion
----------

[WebProfilerBundle] Fix time panel legend buttons

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #33536
| License       | MIT
| Doc PR        | -

It fixes the buttons multiple generations and the toggle behavior as well.

Commits
-------

7f4c8d3 [WebProfilerBundle] Fix time panel legend buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review WebProfilerBundle
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
3 participants
@fabpot @javiereguiluz @carsonbot