Using a PHP class constant for a key in a YAML hash as a method argument produces a ParseException

[rhift]

Symfony version(s) affected: 4.4.7

Description
Virtually the same as #35179 but with different exceptions.

When trying to use a PHP class constant as a YAML key for a hash (as a method argument), I receive one of the following.

• a \Symfony\Component\Yaml\Exception\ParseException with the message The constant "\VENDOR\PRODUCT\Example" is not defined at line 7 (near "!php/const \VENDOR\PRODUCT\Example"). if I use YAML Variant A below.
• a \Symfony\Component\Yaml\Exception\ParseException with the message Malformed inline YAML string: ""\VENDOR\PRODUCT\Example" at line 7 (near ""\VENDOR\PRODUCT\Example"). if I use YAML Variant B below. I observe the same behavior when using single quotes.

How to reproduce
Using the following class and Symfony YAML DI files produces the above.

<?php
declare(strict_types=1);

namespace VENDOR\PRODUCT;

class Example
{
    public const CONSTANT_1 = 'constant_1';
    public const CONSTANT_2 = 'constant_2';

    private $Options;

    public function addOptions(array $options): Example
    {
        $this->Options[] = $options;

        return $this;
    }
}

# YAML Variant A
services:
  VENDOR\PRODUCT\Example:
    class: VENDOR\PRODUCT\Example
    public: false # probably unrelated
    shared: true # probably unrelated
    calls:
      - [addOptions, [{
          !php/const \VENDOR\PRODUCT\Example::CONSTANT_1: 'value_0',
          key_1: "value_1",
          key_2: "value_2"
        }]]

# YAML Variant B
services:
  VENDOR\PRODUCT\Example:
    class: VENDOR\PRODUCT\Example
    public: false # probably unrelated
    shared: true # probably unrelated
    calls:
      - [addOptions, [{
          !php/const "\VENDOR\PRODUCT\Example::CONSTANT_1": 'value_0',
          key_1: "value_1",
          key_2: "value_2"
        }]]

Also, the control case and global PHP constants (in both variants) work as expected, i.e:

# YAML Variant A
services:
  VENDOR\PRODUCT\Example:
    class: VENDOR\PRODUCT\Example
    public: false # probably unrelated
    shared: true # probably unrelated
    calls:
      - [addOptions, [{
          !php/const PHP_INT_MAX: "value_0",
          key_1: "value_1",
          key_2: "value_2"
        }]]

# YAML Variant B
services:
  VENDOR\PRODUCT\Example:
    class: VENDOR\PRODUCT\Example
    public: false # probably unrelated
    shared: true # probably unrelated
    calls:
      - [addOptions, [{
          !php/const "PHP_INT_MAX": "value_0",
          key_1: "value_1",
          key_2: "value_2"
        }]]

[xabbuh]

Thank you for the example. This helped to reproduce it. It looks like the parser still doesn't handle constants well in all places.

For example, this doesn't work:

App\Example:
    calls:
      - method: addOptions
        arguments:
          - !php/const App\Example::CONSTANT_1: 'value_0'
            key_1: "value_1"
            key_2: "value_2"

while this parses correctly:

App\Example:
    calls:
      - method: addOptions
        arguments:
          - key_1: "value_1"
            !php/const App\Example::CONSTANT_1: 'value_0'
            key_2: "value_2"

[rhift]

Absolutely, I wasn't really sure what was wrong so I just tried to give the detail that I had at least.

Oh neat!! I didn't realize that that syntax existed for invoking methods, that's so much better! And thanks for the explanation, I reproduced it and have a much clearer understanding of what is wrong now.

Thanks a ton for tracking this down @xabbuh, really appreciated.

[xabbuh]

Thank you for providing this very good example that allows to reproduce it. I don't know how hard it will be to fully fix this, but now I at least have some test input for the parser. 😃