Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing working disableStty method? #36977

Closed
vovayatsyuk opened this issue May 27, 2020 · 2 comments
Closed

Missing working disableStty method? #36977

vovayatsyuk opened this issue May 27, 2020 · 2 comments
Labels
Bug Console Stalled Status: Needs Review

Comments

@vovayatsyuk
Copy link

Symfony version(s) affected: 3.4 and newer

Description
We have a disableStty method in QuestionHelper: https://github.com/symfony/console/blob/master/Helper/QuestionHelper.php#L93-L96
But, since 3.4 QuestionHelper doesn't check the state of this flag, it checks Terminal instead: https://github.com/symfony/console/blob/master/Helper/QuestionHelper.php#L112
Terminal doesn't provide a disableStty method: https://github.com/symfony/console/blob/master/Terminal.php

Possible Solution
Add disableStty to the Terminal class?
@xabbuh xabbuh added the Console label May 27, 2020
@chalasr chalasr mentioned this issue May 29, 2020
Merged
nicolas-grekas added a commit that referenced this issue May 30, 2020
@nicolas-grekas
bug #37007 [Console] Fix QuestionHelper::disableStty() (chalasr)
8e40814 
This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix QuestionHelper::disableStty()

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no>
| Tickets       | -
| License       | MIT
| Doc PR        | -

We broke it when adding `Terminal::hasSttyAvailable()`.
Let's fix it on 3.4 and move it to terminal on master, as suggested in #36977

Commits
-------

5d93b61 [Console] Fix QuestionHelper::disableStty()
@carsonbot
Copy link

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

@vovayatsyuk
Copy link
Author

It was fixed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Console Stalled Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vovayatsyuk @xabbuh @carsonbot