Polyfill new phpunit 9.1 assertions

[nicolas-grekas]

We should polyfill the new assertions added to phpunit 9.1 in our bridge, so that they can be used on lower versions of php:
https://github.com/sebastianbergmann/phpunit/blob/9.1.5/ChangeLog-9.1.md#910---2020-04-03

See links in #32922 for inspiration.

See also https://github.com/sebastianbergmann/phpunit/pull/4210/files

Help wanted!

[phpfour]

@nicolas-grekas I'm up for it ✋

[nicolas-grekas]

Nice thanks, can't wait! (but no hurry either :) )

[phpfour]

Nice thanks, can't wait! (but no hurry either :) )

You're welcome :) I'll get started on this and hopefully will have an update by the weekend 🤞🏼

[derrabus]

@phpfour I started working on this topic a couple of weeks ago. If this commit is helpful for you, feel free to copy over as much as you like. 😃 derrabus@a05d504

[phpfour]

hi @derrabus, thanks for your reference...that's quite a large commit you have...I am thinking whether it would be beneficial if I contribute to your repository to get it completed rather than doing on my own? WDYT?

[wouterj]

You can fetch Derrabus' fork and then cherry-pick the commit into your branch and work from that:

git remote add derrabus https://github.com/derrabus/symfony.git
git fetch derrabus
git cherry-pick a05d50

Or you can download the raw diff of that commit and apply it locally:

wget https://github.com/derrabus/symfony/commit/a05d504971bbbd6a4e2ef27fbec47d53b61a4cdd.diff
git apply a05d504971bbbd6a4e2ef27fbec47d53b61a4cdd.diff

[derrabus]

The commit is rather large because I've partly migrated the Symfony test suite to the polyfilled methods already. I don't think that this is necessary just yet. The interesting part is in PolyfillAssertTrait.php.

[nicolas-grekas]

I confirm migrating the test suite is not desired unless some methods are deprecated. This will save merge conflicts.

[phpfour]

Thanks guys for the direction, hoping to back soon with some update.

[derrabus]

@phpfour Is there anything I can do to support you?

[phpfour]

I've just pushed the commit and created the PR, sorry this has been sitting idle for a few days 😔

@nicolas-grekas @derrabus would request your review 🙏