[Serializer] paralell XMLEncoder::encode can cause "Wrong Document Error"

[connorhu]

Symfony version(s) affected: 5.0

Description
If you start an XMLEncode::encode process in the middle of a normalization (you need to create an base64 encoded XML sub document), cause an "Wrong Document Error" DomDocument exception at:

symfony/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php

Line 448 in 3e57f1f

$parentNode->appendChild($node);

Here is the call stack:

• The app call the serialize with: $serializer->serialize($data, "xml", [...context...]);
• The first serialize call the createDomDocument at:
  

  symfony/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php

  Line 93 in 3e57f1f

  $this->dom = $this->createDomDocument($context);

• The XMLEncoder call normalizer at:
  

  symfony/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php

  Line 415 in 3e57f1f

  $data = $this->serializer->normalize($data, $this->format, $this->context);

• In CustomNormalizer::normalize we call
  $serializer->serialize($otherdata, "xml", [...other context...]);
• Second serialize override dom at:
  

  symfony/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php

  Line 93 in 3e57f1f

  $this->dom = $this->createDomDocument($context);

• When we done the normalization the encoder fails here because the second serializer did override the dom:
  

  symfony/src/Symfony/Component/Serializer/Encoder/XmlEncoder.php

  Line 448 in 3e57f1f

  $parentNode->appendChild($node);

How to reproduce
Create an XML with an base64 encoded xml subcontent:

<?xml version="1.0"?>
<node>...base64encoded xml...</node>

xml to base64 encode:

<?xml version="1.0"?>
<node2>test</node2>

Possible Solution
DOMDocument of XMLEncoder should stackable.

Additional context
I will post repo, test and PR later.

[connorhu]

Here is a repo with a test file:
https://github.com/connorhu/symfony-serializer
https://github.com/connorhu/symfony-serializer/blob/master/test.php

[carsonbot]

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

[carsonbot]

Friendly reminder that this issue exists. If I don't hear anything I'll close this.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!