Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ldap] Warning on reset pagination #38874

Closed
a-menshchikov opened this issue Oct 28, 2020 · 5 comments
Closed

[Ldap] Warning on reset pagination #38874

a-menshchikov opened this issue Oct 28, 2020 · 5 comments
Labels
Bug Ldap Status: Needs Review

Comments

@a-menshchikov
Copy link
Contributor

Symfony version(s) affected: 5.1.8

Description
After #38392 \Symfony\Component\Ldap\Adapter\ExtLdap\Query::resetPagination returns warning from Adapter/ExtLdap/Query.php::239

Warning: ldap_parse_result() expects parameter 2 to be resource, int given

I can suppose that cause is on Adapter/ExtLdap/Query.php::177
@a-menshchikov
Copy link
Contributor Author

@lucasaba Could you watch this?

Nek- added a commit to Nek-/symfony that referenced this issue Oct 28, 2020
@Nek-
fix(ldap): pagination for PHP 7.4 & 8.0
ec99d01 
After PR symfony#38392 there is a little issue in the Symfony code base that
occurs only for PHP 7.4 and PHP 8.0.

This is related to issue symfony#38874
@Nek- Nek- mentioned this issue Oct 28, 2020
Closed
@Nek-
Copy link
Contributor

Nek- commented Oct 28, 2020

Hello @a-menshchikov does this ( #38875 ) fix your problem as expected?

Nek- added a commit to Nek-/symfony that referenced this issue Oct 29, 2020
@Nek-
fix(ldap): pagination for PHP 7.4 & 8.0
2e8f4ff 
After PR symfony#38392 there is a little issue in the Symfony code base that
occurs only for PHP 7.4 and PHP 8.0.

This is related to issue symfony#38874
@Nek- Nek- mentioned this issue Oct 29, 2020
Closed
@lucasaba
Copy link
Contributor

@a-menshchikov I'm on it. But that's quite strange: how is the resource supposed to change and become an int ?

Nek- added a commit to Nek-/symfony that referenced this issue Oct 29, 2020
@Nek-
fix(ldap): pagination for PHP 7.4 & 8.0
02f4ffd 
After PR symfony#38392 there is a little issue in the Symfony code base that
occurs only for PHP 7.4 and PHP 8.0.

This is related to issue symfony#38874
@a-menshchikov
Copy link
Contributor Author

@Nek- yes, your fix helped.

@derrabus derrabus added the Ldap label Oct 29, 2020
Nek- added a commit to Nek-/symfony that referenced this issue Oct 29, 2020
@Nek-
fix(ldap): pagination for PHP 7.4 & 8.0
65c1166 
After PR symfony#38392 there is a little issue in the Symfony code base that
occurs only for PHP 7.4 and PHP 8.0.

This is related to issue symfony#38874
@lucasaba
Copy link
Contributor

Just to confirm that I've added the error. As @jderusse pointed out in #38875 , I've changed a method with the wrong name.

@jderusse jderusse mentioned this issue Nov 7, 2020
Merged
@fabpot fabpot closed this as completed Nov 9, 2020
fabpot added a commit that referenced this issue Nov 9, 2020
@fabpot
bug #39031 [Ldap] Fix pagination (jderusse)
46410f8 
This PR was merged into the 4.4 branch.

Discussion
----------

[Ldap] Fix pagination

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #38874
| License       | MIT
| Doc PR        | N/A

This replaces #38875 to fix a bug introduced by #38392

Commits
-------

4fe0a6f Fix LDAP pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Ldap Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fabpot @lucasaba @Nek- @derrabus @a-menshchikov @carsonbot