Incorrect behavior of PropertyAccessor when dynamic property contains dot

[kefzce]

Symfony version(s) affected: 5.2.0

Description
Attempting to serialize an array which casted to object, if any of these properties contains "." (dot)
PropertyAccess resolvePath(getPropertyPath) behaves weird

symfony/src/Symfony/Component/PropertyAccess/PropertyPath.php

Lines 88 to 90 in 0758e59

	// first element is evaluated differently - no leading dot for properties
	$pattern = '/^(([^\.\[]++)|\[([^\]]++)\])(.*)/';

How to reproduce

    protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $arr = [
          "No. of Rows" => "somedata"
        ];

        $obj = (object) $arr;
        dump($obj->{"No. of Rows"}); // some data output
        $propertyAccessor = PropertyAccess::createPropertyAccessorBuilder()
            ->getPropertyAccessor();

        // instead of throwing an exception the following code returns null
        // in case if we decide to use disableExceptionOnInvalidPropertyPath
        $value = $propertyAccessor->getValue($obj, 'No. of Rows'); //exception
        dump($value);


        return Command::SUCCESS;
    }

Exception will be thrown, which we can handle by using disableExceptionOnInvalidPropertyPath
if we are using PropertyAccessor directly,
but not in case when we are using ObjectNormalizer / Serializer e.g $this->json($object)
propertyPath
resolve it as two elements

elements = {array} [2]
 0 = "No"
 1 = " Of Rows"

and of course an attempt to access the object with any of these properties
e.g

$obj->{"No"}
$obj->{" Of Rows"}

makes no sense, cause $zval does not know anything about these properties, but knows about No. of Rows
Possible Solution
Process this case correctly :D

Additional context
The example above was reproduced with simple test command in CLI environment

[sstok]

You can try using the PropertyPathBuilder with explicitly calling appendProperty().
The property-path string currently doesn't support special-case names.

Status: Reviewed

Or you can try casting an object to an array instead? And use an index-path.

[kefzce]

You can try using the PropertyPathBuilder with explicitly calling appendProperty().
The property-path string currently doesn't support special-case names.

Status: Reviewed

Or you can try casting an object to an array instead? And use an index-path.

Is it possible to do it, when I'm using Serializer directly?
My case was about an exception during serialization

$this->json( (object) $myArray) );

[sstok]

The ObjectNormalizer allows to pass a PropertyAccessor instance, unless there is a Framework configuration (I haven't used the serializer myself) you can overwrite (decorate) the ObjectNormalizer service with a custom PropertyAccessor service.

Or we could change the PropertyPath parsing logic to handle special cases like
"No . way anyone ""Would"" do "" this".'[right?]'" (using quote doubling as escaping). As there are more special cases that could conflict.

But before we move forward with this idea I think it's best to hear from others 😄 technically it's possible 👍🏼

[carsonbot]

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

[carsonbot]

Could I get a reply or should I close this?

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

[kefzce]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

Could we open it once again ? I guess if no one will try to fix it, ill do it at my own.

[carsonbot]

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

[carsonbot]

Friendly ping? Should this still be open? I will close if I don't hear anything.

[carsonbot]

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!