Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Command workflow:dump not working #43938

Closed
ch2877 opened this issue Nov 5, 2021 · 4 comments · Fixed by #43940
Closed

[Workflow] Command workflow:dump not working #43938

ch2877 opened this issue Nov 5, 2021 · 4 comments · Fixed by #43940

Comments

@ch2877
Copy link

ch2877 commented Nov 5, 2021

Symfony version(s) affected

5.4

Description

I tryed to dump a workflow in Symfony 5.4 and kept getting the Message

No service found for "workflow.xyz" nor "state_machine.xyr".

I tryed to reproduce it in Symfony 5.3 and found that it is working, but got the following warning:

User Deprecated: Since symfony/framework-bundle 5.3: Accessing the "workflow.xyz" service directly from the container is deprecated, use dependency injection instead.

How to reproduce

Create a Workflow in Symfony 5.4 and try to dump it:
https://github.com/ch2877/symfony_issue_43938

Possible Solution

No response

Additional Context

No response

@xabbuh
Copy link
Member

xabbuh commented Nov 5, 2021

Can you create a small example application that allows to reproduce your issue?

@ch2877
Copy link
Author

ch2877 commented Nov 5, 2021

@noniagriconomie
Copy link
Contributor

noniagriconomie commented Nov 5, 2021

I see the problem, when discussing with @StaffNowa on PR #43848 we may have misunderstood ourselves, between workflowNames and workflowIds (with prefix workflow. and state_machine.)
I will provide a fix for v5.4

@StaffNowa
Copy link
Contributor

StaffNowa commented Nov 5, 2021

I see the problem, when discussing with @StaffNowa on PR #43848 we may have misunderstood ourselves, between workflowNames and workflowIds (with prefix workflow. and state_machine.) I will provide a fix for v5.4

Yes, we had before prefixes validation in the switch case.

@ch2877 ch2877 changed the title Command workflow:dump not working [Workflow] Command workflow:dump not working Nov 5, 2021
@fabpot fabpot closed this as completed Nov 5, 2021
fabpot added a commit that referenced this issue Nov 5, 2021
…low name and workflow id (noniagriconomie)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Fix logic in workflow:dump between workflow name and workflow id

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #43938
| License       | MIT

As described in #43938 (comment)
the command need a workflow name as argument, but the array contains workflows ids (prefix `workflow|state_machine`)

Commits
-------

d043641 [FrameworkBundle] Fix logic in workflow:dump between workflow name and workflow id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants