[Process] argv array in env resulting in "Array to string conversion" error

[scuben]

Symfony version(s) affected

5.3.11

Description

After upgrading the process component from 5.3.7 to 5.3.11 I sometimes get the following error:
Notice: Array to string conversion on https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Process/Process.php#L344

A simple dump($k, $v) showed "argv" and [].

How to reproduce

not sure (yet) but version 5.3.11 required.

Possible Solution

No response

Additional Context

No response

[nicolas-grekas]

Can you please provide a reproduder for this? I fail to see how this can happen.

[rmj-s]

I'm also facing this issue. is_string check was removed for $_SERVER values in #44070, resulting in argv = [] to be passed here:

symfony/src/Symfony/Component/Process/Process.php

Line 344 in a8fc556

$envPairs[] = $k.'='.$v;

[mpiecko]

I'm having exact the same Exception "Notice: Array to string conversion" after the update when using Process::fromShellCommandline() ... will try to narrow the issue.

[nicolas-grekas]

Thank you all but there is no question whether some of you experience this or not.
The question is rather: how do I reproduce so that I could fix it?
Alternatively, could you please debug where this argv array comes from?
E.g. what does var_dump($env) show for you right before the call to array_intersect_key() in getDefaultEnv()? And just after it?

[mpiecko]

Ok, I dumped the $env array in the loop. and it seems this is the item which fails:
"argv" => []

[nicolas-grekas]

At which line did you dump this please?

[mpiecko]

Yes, sorry:

symfony/src/Symfony/Component/Process/Process.php

Line 344 in a8fc556

$envPairs[] = $k.'='.$v;

[nicolas-grekas]

OK thanks. Can you please try dumping as I suggested in #44197 (comment)?

[mpiecko]

This is the only array value from the $env variable:

[nicolas-grekas]

Can you please try #44208?

[mpiecko]

Yes, that fixed it 🎉. Just FYI: both items argv and argc where available in an $env dump before and after array_intersect_key() Comment: #44197

[nicolas-grekas]

Thanks for the help debugging this!

[pks0268]

Notice: Array to string conversion coming on before response from the version 4.4