Bootstrap radio-inline no more working on expended choice types

[Seb33300]

Symfony version(s) affected

4.4.38

Description

Since this PR has been merged, the radio-inline bootstrap class cannot be properly applied to radio input labels on expended ChoiceType / EntityType when using Bootstrap 3 layout.

The issue is caused by this part of code removed from bootstrap_3_layout.html.twig

{%- if parent_label_class is defined -%}
    {%- set label_attr = label_attr|merge({class: (label_attr.class|default('') ~ ' ' ~ parent_label_class)|trim}) -%}
{%- endif -%}

The radio-inline class is handled here:

symfony/src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_layout.html.twig

Line 48 in 9400311

{%- if 'radio-inline' in parent_label_class -%}

The same issue probably occurs on other bootstrap versions since other layouts were modified too.

How to reproduce

twig:
    form_themes:
        - 'bootstrap_3_layout.html.twig'

->add('template', EntityType::class, [
    'class' => Template::class,
    'choice_label' => 'name',
    'expanded' => true,
])

{{ form_widget(form.template, {'label_attr': {'class': 'radio-inline'}}) }}

Result:

<label for="..." class="required"><input...></label>
<label for="..." class="required"><input...></label>
...

Before:

<label for="..." class="required radio-inline"><input...></label>
<label for="..." class="required radio-inline"><input...></label>
...

[Seb33300]

Just found a similar issue: #44332

[xabbuh]

Can you create a small example application that allows to reproduce your issue?

[xabbuh]

I am going to close here for now due to the lack of feedback. Please let us know when you have more information and we can consider to reopen.

[dragu]

Same here on Symfony 5.4.7

[BangouraAlseny]

Can you create a small example application that allows to reproduce your issue?

Hello @xabbuh ,
I got the same issue. So, I did a small example project to reproduce it as you asked.

https://github.com/BangouraAlseny/symfony_issue_45727

Bug result

Excepted result

[Seb33300]

This issue could be fixed by #18318

[carsonbot]

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

[carsonbot]

Could I get an answer? If I do not hear anything I will assume this issue is resolved or abandoned. Please get back to me <3

[xabbuh]

see #49421