Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TwigBundle][TwigBridge] Wrong dependency version #50245

Closed
SVillette opened this issue May 5, 2023 · 1 comment · Fixed by #50248
Closed

[TwigBundle][TwigBridge] Wrong dependency version #50245

SVillette opened this issue May 5, 2023 · 1 comment · Fixed by #50248

Comments

@SVillette
Copy link
Contributor

Symfony version(s) affected

6.3

Description

As @curry684 stated in this comment, if an application requires TwigBundle:6.3 but TwigBridge:6.2, an error will be triggered when the container is compiled.

How to reproduce

I reproduced this issue by only upgrading symfony/twig-bundle to 6.3.

{
        "symfony/twig-bridge": "6.2.*",
        "symfony/twig-bundle": "6.3.*-dev",
 }

And I get the following error

In App_KernelDevDebugContainer.php line 935:
                                                                                                               
  Attempted to call an undefined method named "setLocaleSwitcher" of class "Symfony\Bridge\Twig\AppVariable".

Possible Solution

Set 6.3 as symfony/twig-bridge minimum version in symfony/twig-bundle dependencies seems to fix the issue.

Additional Context

If core members agree with this fix, I can open a PR.

@stof
Copy link
Member

stof commented May 5, 2023

This is indeed the right fix. Please open the PR.

@fabpot fabpot closed this as completed May 7, 2023
fabpot added a commit that referenced this issue May 7, 2023
…version (SVillette)

This PR was merged into the 6.3 branch.

Discussion
----------

[TwigBundle] fixed wrong `symfony/twig-bridge` dependency version

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #50245
| License       | MIT
| Doc PR        | -

`TwigBundle` had wrong dependency version  after #49913. This PR fixes this issue.

Commits
-------

c05f484 fix(twig-bundle): fixed wrong `symfony/twig-bridge` dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants