-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AssetMapper] bootstrap icons works with direct link not with assetmapper require #52620
Comments
This package is not delivered as en ESM bundle, and the package.json does not list the woff / woff2 files so it may be something to digg As stated in the documentation, when you need to deal with non ESM packages, sometimes it just works... and sometimes you have a bit of manual work to do :) |
@smnandre yes, but @weaverryan has done a lot of work to handle more cases in 6.4. Given the ubiquity of bootstrap-icons, if it doesn't work out of the box, perhaps he could give guidance to the developer as to what's needed so that it does. There were issues with datatables.net that were resolved when the two of them looked at the problem together. |
… in CSS (weaverryan) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [AssetMapper] Fix: also download files referenced by url() in CSS | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52620 | License | MIT Hi! `@tacman` found another situation where our "asset downloader" wasn't complete. If we're downloading a CSS file, it may reference other files via `url()`. In #52620, these were font files, but they could be images or even other CSS Files. Currently, we do NOT download these, so the local references fail. This fixes that. I tried to keep the PR as small as possible, given the late stage of 6.4. But this *is* a bug fix: the downloader currently doesn't work for CSS files with `url()` inside. Tested locally on ux.symfony.com with the bootstrap-icons package. Cheers! Commits ------- ca90ed8 [AssetMapper] Fix: also download files referenced by url() in CSS
I can confirm that the above script now works with the -dev branch of 6.4. THANKS!! I'm guessing we'll see RC2 very soon. |
Symfony version(s) affected
6.4
Description
works as expected, but
doesn't.
See https://bootstrap-icons-bug.survos.com/ for a working and non-working version.
How to reproduce
Possible Solution
There's something amiss with parsing out the fonts, the javascript console gives some warnings/errors.
Additional Context
No response
The text was updated successfully, but these errors were encountered: