[DependencyInjection] unable to make lazy service from readonly class

[kor3k]

Symfony version(s) affected

6.4.3

Description

marking any readonly class as a lazy service results in an error.

the bug seems not on symfony side, but on
https://github.com/FriendsOfPHP/proxy-manager-lts
side, as it does not count for readonly classes while creating proxies. (#53843 (comment))

How to reproduce

1. create readonly class

<?php

namespace App;

readonly class TestService
{
    public function foo(): string
    {
        return 'bar';
    }
}

2. mark it as lazy

services:
  App\TestService:
    lazy: true

3. inject it anywhere, e.g. in controller

<?php

namespace App\Controller;

use App\TestService;
use Symfony\Component\Routing\Attribute\Route;

class TestController
{
    #[Route(path: '/test')
    public function __invoke(TestService $service): Response
    {
        return new Response($service->foo());
    }
}

4. result is error

Compile Error: Non-readonly class ContainerBh60GB2\TestServiceGhost93bb697 cannot extend readonly class App\TestService

Possible Solution

No response

Additional Context

No response

[nicolas-grekas]

We don't use that lib anymore so this is a Symfony thing. The DI component together with the VarExporter one are responsible for generating the proxies. Would you like to have a look?
This line is supposed to generate a readonly proxy class:

symfony/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php

Line 136 in 2868d0d

return (\PHP_VERSION_ID >= 80200 && $class?->isReadOnly() ? 'readonly ' : '').'class '.$proxyClass.ProxyHelper::generateLazyProxy($class, $interfaces);

Could you please see if you can debug and possibly fix the issue?

[kor3k]

@nicolas-grekas that's weird, it does not get to this line at all.

i'll update

[nicolas-grekas]

Oh, maybe we're missing the readonly logic on L108 then?

[kor3k]

@nicolas-grekas

this is truthy

if ($asGhostObject) {

so the readonly is missing on

symfony/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php

Line 108 in 2868d0d

return 'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);

[kor3k]

but when i change the L108 to

return (\PHP_VERSION_ID >= 80200 && $class?->isReadOnly() ? 'readonly ' : '').'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);

then i get (after c:c)

Warning: require(/app/var/cache/dev/ContainerUlZygQT/TestServiceGhost93bb697.php): Failed to open stream: No such file or directory

[kor3k]

@nicolas-grekas

there seems to be a problem with filename. because it does generate the class, but names it class.php

  GNU nano 6.2 /app/var/cache/dev/ContainerUlZygQT/class.php                                                                                                                                 
<?php

namespace ContainerUlZygQT;
include_once \dirname(__DIR__, 4).'/src/TestService.php';

readonly class TestServiceGhost93bb697 extends \App\TestService implements \Symfony\Component\VarExporter\LazyObjectInterface
{
    use \Symfony\Component\VarExporter\LazyGhostTrait;

    private const LAZY_OBJECT_PROPERTY_SCOPES = [];
}

// Help opcache.preload discover always-needed symbols
class_exists(\Symfony\Component\VarExporter\Internal\Hydrator::class);
class_exists(\Symfony\Component\VarExporter\Internal\LazyObjectRegistry::class);
class_exists(\Symfony\Component\VarExporter\Internal\LazyObjectState::class);

if (!\class_exists('class', false)) {
    \class_alias(__NAMESPACE__.'\\class', 'class', false);
}

[nicolas-grekas]

Another change is needed. Up to turn this into a PR and add a test case while doing so?

diff --git a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
index 81b500c5ad7..23e65483b03 100644
--- a/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
+++ b/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php
@@ -624,7 +624,9 @@ EOF;
                 $proxyCode = substr(self::stripComments($proxyCode), 5);
             }
 
-            $proxyClass = explode(' ', $this->inlineRequires ? substr($proxyCode, \strlen($code)) : $proxyCode, 3)[1];
+            $proxyClass = $this->inlineRequires ? substr($proxyCode, \strlen($code)) : $proxyCode;
+            $i = strpos($proxyClass, 'class');
+            $proxyClass = substr($proxyClass, 6 + $i, strpos($proxyClass, ' ', 7 + $i) - $i - 6);
 
             if ($this->asFiles || $this->namespace) {
                 $proxyCode .= "\nif (!\\class_exists('$proxyClass', false)) {\n    \\class_alias(__NAMESPACE__.'\\\\$proxyClass', '$proxyClass', false);\n}\n";
diff --git a/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php b/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php
index b1df5f0f0cd..0d4426c4403 100644
--- a/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php
+++ b/src/Symfony/Component/DependencyInjection/LazyProxy/PhpDumper/LazyServiceDumper.php
@@ -105,7 +105,7 @@ final class LazyServiceDumper implements DumperInterface
 
         if ($asGhostObject) {
             try {
-                return 'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);
+                return (\PHP_VERSION_ID >= 80200 && $class?->isReadOnly() ? 'readonly ' : '').'class '.$proxyClass.ProxyHelper::generateLazyGhost($class);
             } catch (LogicException $e) {
                 throw new InvalidArgumentException(sprintf('Cannot generate lazy ghost for service "%s".', $id ?? $definition->getClass()), 0, $e);
             }