Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid making cache.app tag-aware #54339

Open
rpkamp opened this issue Mar 19, 2024 · 2 comments
Open

Forbid making cache.app tag-aware #54339

rpkamp opened this issue Mar 19, 2024 · 2 comments
Labels
Cache DX DX = Developer eXperience (anything that improves the experience of using Symfony)

Comments

@rpkamp
Copy link
Contributor

rpkamp commented Mar 19, 2024

Description

Follow-up from twigphp/Twig#3869

Since app.cache.tagware exists by default, we should not allow app.cache to be taggable. Whenever people try to configure app.cache as taggable we should inform them about app.cache.taggable.

Ideally, in the current version this would raise a deprecation notice, and it should be completely forbidden in the next Symfony version.

Example

No response
@rpkamp rpkamp mentioned this issue Mar 19, 2024
Closed
@xabbuh xabbuh added DX DX = Developer eXperience (anything that improves the experience of using Symfony) Cache labels Mar 20, 2024
@chalasr
Copy link
Member

chalasr commented Mar 24, 2024

Proposal sounds good to me. Up for a PR targeting 7.1?

@rpkamp
Copy link
Contributor Author

rpkamp commented Mar 25, 2024

Sure I can have a look somewhere in the next few weeks. I'm kinda busy ATM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cache DX DX = Developer eXperience (anything that improves the experience of using Symfony)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rpkamp @xabbuh @chalasr