Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError on ProgressBar #54419

Merged
merged 1 commit into from Mar 28, 2024
Merged

Fix TypeError on ProgressBar #54419

merged 1 commit into from Mar 28, 2024

Conversation

Fan2Shrek
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #54386
License MIT

ProgressBar->getMessage() returns null if the message is not defined

@Fan2Shrek Fan2Shrek requested a review from chalasr as a code owner March 27, 2024 09:59
@carsonbot carsonbot added this to the 6.4 milestone Mar 27, 2024
@Fan2Shrek Fan2Shrek changed the title Fix TypeError on ProgressBar [Console] Fix TypeError on ProgressBar Mar 27, 2024
@carsonbot carsonbot changed the title [Console] Fix TypeError on ProgressBar Fix TypeError on ProgressBar Mar 27, 2024
@xabbuh
Copy link
Member

xabbuh commented Mar 28, 2024

Thank you @Fan2Shrek.

@xabbuh xabbuh merged commit 04d547d into symfony:6.4 Mar 28, 2024
4 of 10 checks passed
This was referenced Apr 3, 2024
xabbuh added a commit that referenced this pull request Apr 3, 2024
…abbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Console] return null when message with name is not set

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

same as #54419 but for the `5.4` branch

Commits
-------

050d8e8 return null when message with name is not set
github-merge-queue bot pushed a commit to Lendable/composer-license-checker that referenced this pull request Apr 4, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [symfony/console](https://symfony.com)
([source](https://togithub.com/symfony/console)) | `7.0.4` -> `7.0.6` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/symfony%2fconsole/7.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/symfony%2fconsole/7.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/symfony%2fconsole/7.0.4/7.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/symfony%2fconsole/7.0.4/7.0.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>symfony/console (symfony/console)</summary>

### [`v7.0.6`](https://togithub.com/symfony/console/releases/tag/v7.0.6)

[Compare
Source](https://togithub.com/symfony/console/compare/v7.0.4...v7.0.6)

**Changelog**
(symfony/console@v7.0.5...v7.0.6)

- bug
[symfony/symfony#54435](https://togithub.com/symfony/symfony/issues/54435)
\[Console] respect multi-byte characters when rendering vertical-style
tables ([@&#8203;xabbuh](https://togithub.com/xabbuh))
- bug
[symfony/symfony#54419](https://togithub.com/symfony/symfony/issues/54419)
Fix TypeError on ProgressBar
([@&#8203;Fan2Shrek](https://togithub.com/Fan2Shrek))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Lendable/composer-license-checker).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants