[Form] NumberType should display an error when a string is submitted

[bdmu]

Hello,

In Symfony 2.1.1, when a string such '1aaa' is input in a 'number' Form field, there is no validation error and the string value '1aaa' is converted in the numeric value '1'.

It looks like it is due to NumberFormatter in NumberToLocalizedStringTransformer.reverseTransform

a small php script which reproduces the conversion from string to numeric:

setAttribute(\NumberFormatter::FRACTION_DIGITS, 3); $formatter->setAttribute(\NumberFormatter::ROUNDING_MODE, \NumberFormatter::ROUND_HALFUP); $formatter->setAttribute(\NumberFormatter::GROUPING_USED, false); return $formatter; } $formatter = getNumberFormatter(); $value = $formatter->parse('1aaa'); echo "Error Code:".$formatter->getErrorCode()."\n"; echo "intl_is_failure:".intl_is_failure($formatter->getErrorCode())."\n"; echo "is_numeric:".is_numeric($value)."\n"; echo $value; => Error Code:0 intl_is_failure: is_numeric:1 1 Best regards, Christophe

[webmozart]

Thank you for taking the time to report this issue! As you found out, NumberFormatter is the reason for this behavior. When #2059 is solved, this issue can probably be tackled as well.

[ericclemmons]

I've been struggling with this as well when a bad value is put in, like foo.

Would it be acceptable to at least throw an exception in NumberToLocalizedStringTransformer if $value doesn't at least contain a single digit?

[webmozart]

@ericclemmons I cannot reproduce your issue. When I enter foo or foo1, I get an error on the field. Only if I enter 1foo, the input is interpreted as 1.

[webmozart]

This is fixed in the referenced PR.