$event->getData() returns null for an embedded form

[waiting-for-dev]

Related with #5694

Using $event->getData() within an event for an embedded form return null.

public function buildForm(FormBuilderInterface $builder, array $options)
{
     $builder->addEventListener(FormEvents::POST_SET_DATA, function ($event) {
         die(var_dump($event->getData())); //Return NULL for embedded forms, and the entity for non-embedded forms
     });
}

I have tested it for a non-persisted entity with properties assigned in the controller. But it should be the same for persisted entities, I suppose.

[webmozart]

Hi, thank you for reporting this issue! Could you please publish a fork of symfony-standard that reproduces your problem? In general, this functionality is known to work.

[waiting-for-dev]

Ok, I will prepare it when I have a bit of time...

Thanks!

[webmozart]

Any news?

[waiting-for-dev]

Wow, I didn't remember this, to be honest. I close the issue because I find too difficult to get the time... I'll reopen if I have the time to review this.

[webmozart]

GitHub never forgets ;)

[taylorludwig]

for anyone else that runs across this. I ran into the same issue in symfony 2.1 but performed the same test in 2.3 and it was fixed.

[ghost]

so, what should we do if we are working with symfony2.1? is there any solution for that?

[stof]

@p-shad your solution is updating to a maintained version of Symfony. The 2.1 serie reached its end of maintenance several months ago

[sibok]

Hi, i'm on Symfony 2.3.9 and the issue exposed here is still reproducible so it already exists and i'm suffering from it. Could you please reopen that issue?

class ParentFormType extends AbstractType
{
public function buildForm( FormBuilderInterface $builder, array $options )
{
$builder->add( 'files', 'collection', array(
'type' => new FileType(),
'allow_add' => true,
'allow_delete' => true,
'prototype' => true,
'by_reference' => false
);
}
}

class FileType extends AbstractType
{
    public function buildForm( FormBuilderInterface $builder, array $options )
    {

/*Each one of bellow calls returns NULL
print_r( $builder->getData() );
print_r( $builder->getForm()->getData() );
*/
$builder->addEventListener(\Symfony\Component\Form\FormEvents::POST_SET_DATA,
function( \Symfony\Component\Form\FormEvent $event )
{
$data = $event->getData();
//Returns NULL
print_r( $data);
die();
}
);

        $builder->add( 'file', 'file', array(
                                                'required'      => false,
                                                'file_path'     => 'file',
                                                'label'         => 'Select a file to be uploaded',
                                                'constraints'   => array(
                                                    new File(
                                                        array(
                                                            'maxSize' => '1024k',        
                                                        )
                                                    )
                                                )
            )
        );
    }

    public function setDefaultOptions( \Symfony\Component\OptionsResolver\OptionsResolverInterface $resolver )
    {
        return $resolver->setDefaults( array() );
    }

    public function getName()
    {
        return 'FileType';
    }
}

[rfink]

Also having this issue

[cordoval]

Can some do what @webmozart proposed more than a year ago?

[cordoval]

please @sibok close your issue 10300 as it is related to this and is the same issue #10300
@waiting-for-dev please reopen this issue
I will fork SE and try to reproduce with the information given in 10300 and in comment

[stof]

@cordoval this issue has been closed 11 months ago

[stof]

and I don't see the point of closing an opened issue and reopening a closed one. Why not keeping them in their current state ?

[cordoval]

trying to reproduce here https://github.com/cordoval/symfony-standard/pull/13/files, i get of course null but it is more because of other reasons and lack of input as to the templates. I found very bad errors on your code @sibok

[sibok]

Could you please point me the very bad errors? thx

[cordoval]

file_path is non existant is one, but check the diff above i provided and compare to your code.
It would be great if you do reproduce the problems in a SE like i did but add more details on the views. That would definitely help @webmozart or others to reproduce and tackle the issue.

[sibok]

Excuses, file_path was an option attribute which works for me due to a File Form Field extension i already made.

Anyway, the issue still persists and as said for stof, i'm aware of that issue for about one year at least. I'm closing the issue right now, do someone know if it's going to be fixed? Thx

[florinutz]

$builder->addEventListener(FormEvents::PRE_SET_DATA, function(FormEvent $event){

$event->getData() is null and it shouldn't be.

[maher88]

Hi, I have the same problem.
Did anyone found a solution or simplier way to do this?

[InformaticRevolution]

Hi,

I also have the same problem.

[ghost]

Same problem here

[qferr]

Not resolved ? Because I have the same problem... .

[Djevil83]

Hi, @webmozart I have the same problem.
I found that the var_dump in the embedded form with:

    $builder
        ->addEventListener(FormEvents::PRE_SET_DATA, function (FormEvent $event) {
            var_dump($event->getData());
            exit();
        });

always return null when in the parent form the collection field have the option 'allow_add' => true,
When i change this option to 'allow_add' => false, the $event->getData() return the entity as expected.

Could you please re open this issue ?

[MConrotte]

Hi,

I also have the same problem.
Do someone know if really it's going to be fixed ?

[nothingaa]

Having the same problem.

[Djevil83]

@MConrotte and @nothingaa. The problem is still there if you set the option 'allow_add' => false instead of 'allow_add' => true in the parent collection form field or this change nothing ?

[nicolaskern]

This is rather annoying to have to disable allow_add as, right now, I have to allow adds.

After having given a better insight, I noticed that the child form is called for each item of your collection, plus called the first time without any argument nor data.

The quick fix I found is to test if getData() is null or not. Works for me with allow_add => true.

$builder->addEventListener(FormEvents::POST_SET_DATA, function (FormEvent $event) {
    if (null != $event->getData()) {
    }
}

[vdrouet]

Same problem here, thanks @nicolaskern for the tip !

[alrayyes]

Same issue here. Thanks to @nicolaskern as well for the quick fix.

[nicolaskern]

You're much welcome ;)

[boltunoreh]

try this maybe:
$data = $event->getData();
$filiation = null == $data ? null : $data->getFiliation();
$formModifier($event->getForm(), $filiation);

[moniprecup]

Any news about this? I'm having the same problem.

[skrosoft]

In my case, the problem is that I want to add field, depending of the value of the getData() instance and the EventListener doesnt allow me to add field to the form.

[eudiegoborgs]

Solution found to use POST_SET_DATA, using it, my function to call twice just to do a check for case getData == null not executed

See this:
FormEvents::POST_SET_DATA, function (FormEvent $event) { if (is_null($event->getData())) { return; } *write your code action here* }

[randywatson1979]

My situation was that I assumed that a collectionType field which already contains existing objects, can have prototype at the same time (triggered by "allow_add => true"), but in fact that causes the data in PRE_SET_DATA event to be null.
I ended up separating this field into two collectionType. One for loading the existing objects (prototype => false) and the second one for prototype. Hope this helps anyone.