Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude tests from zips via gitattributes #6374

Closed
tvlooy opened this issue Dec 15, 2012 · 2 comments
Closed

Exclude tests from zips via gitattributes #6374

tvlooy opened this issue Dec 15, 2012 · 2 comments

Comments

@tvlooy
Copy link
Contributor

tvlooy commented Dec 15, 2012

I have an issue regarding this commit 462dddf

I use the Symfony\Component\Form\Tests\FormBuilderInterface in my own tests (like suggested in 6b5b625)

Example: https://github.com/tvlooy/ReadingCorner/blob/master/htdocs/src/Ctors/ReadingCornerBundle/Tests/Form/AuthorTypeTest.php

At the moment, my tests fail because the Tests FormBuilderInterface class is no longer provided in the Standard Edition.

I'm no expert in tests so your advice would be very welcome.
@igorw
Copy link
Contributor

igorw commented Dec 15, 2012

I propose we create a Test directory in addition to the Tests directory which is not excluded from the zips. This is consistent with the FrameworkBundle which has a Test and a Tests directory.

@tvlooy
Copy link
Contributor Author

tvlooy commented Dec 15, 2012

Attached code #6375

@fabpot fabpot closed this as completed in f56a2b9 Dec 18, 2012
fabpot added a commit that referenced this issue Dec 18, 2012
@fabpot
merged branch tvlooy/form_test (PR #6375)
7bc9caa 
This PR was merged into the master branch.

Commits
-------

cda1621 Move FormInterface too
0544351 Move DeprecationErrorHandler to Test folder so it's not removed when building the zip file
f56a2b9 Fix #6374 move FormBuilderInterface from Tests to Test

Discussion
----------

Fix #6374 move FormBuilderInterface from Tests to Test

---------------------------------------------------------------------------

by fabpot at 2012-12-16T07:47:55Z

Are there any other classes in the tests that might be useful for testing userland forms? ping @bschussek

---------------------------------------------------------------------------

by colinfrei at 2012-12-16T08:24:51Z

The DeprecationErrorHandler will need to be in the Test directory as well, as its handleBC method is used for handling BC code that's not in tests.

---------------------------------------------------------------------------

by colinfrei at 2012-12-16T09:06:51Z

Wanted to make a pull request to tvlooy's branch with the DeprecationErrorHandler stuff, but can't figure out how to do that - the commit is here: colinfrei@ec56379

---------------------------------------------------------------------------

by stof at 2012-12-16T19:53:59Z

@fabpot The other extending interfaces provided for mocking purpose (as mocking an interface extending ``Traversable`` directly does not work). So we have FormInterface too at least
@mlocati mlocati mentioned this issue May 23, 2016
Closed
@arcanedev-maroc arcanedev-maroc mentioned this issue Sep 29, 2016
Closed
@javiereguiluz javiereguiluz mentioned this issue Dec 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @igorw @tvlooy