[HttpKernel] fix issues with TTL based invalidation in the HttpCache #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable correct computation of the age in later requests
|
will review the test failures ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #6746
License of the code: MIT
Set the date in the response before passing it off to the store, to enable correct computation of the age in later requests. Note this will lead to setting the date twice in the case when the response is written to the store. Not sure if it would make sense to do a bigger refactoring.
That being said in case of a bigger refactoring I wonder if it wouldnt make more sense to change a TTL invalidation to an Expire invalidation to reduce the amount of computational work that needs to be done on a cache lookup.