Routing issue with installation in a sub-directory

[DHorchler]

Symfony 2.1:

In parameters.yml I have
sub_dir: /mnc

In config.yml:

sonata:
resource: '@SonataAdminBundle/Resources/config/routing/sonata_admin.xml'
prefix: %sub_dir%/secured/admin
_sonata_admin:
resource: .
type: sonata_admin
prefix: /mnc/secured/admin

Up to here everything works fine, but if I use

sonata:
resource: '@SonataAdminBundle/Resources/config/routing/sonata_admin.xml'
prefix: %sub_dir%/secured/admin
_sonata_admin:
resource: .
type: sonata_admin
prefix: %sub_dir%/secured/admin

I get a route not found error.
I checked that in the latter case the line

if (0 === strpos($pathinfo, '/%sub_dir%/secured/admin')) {

is generated in the cache file appdevUrlMatcher.php, which should in fact be

if (0 === strpos($pathinfo, '/mnc/secured/admin')) {.

Regards

[Tobion]

It's a problem of the loader in SonataAdminBundle and should be reported there. Thanks.

[rande]

@Tobion This issue is not related to the AdminBundle. The parameter provided in the routing file is not translated to the correct value.

[Tobion]

Well, the replacement is done here. Don't know why it wouldn't for the type: sonata_admin. @rande do you know where the problem is?

[rande]

@Tobion the resolve parameter does not seems to replace the prefix. Unless prefix is a default or a requirement

[Tobion]

Prefix is just the prefix of the path. So it is part of the path in the end.

[DHorchler]

I think the problem is not with the route pattern ($pathinfo) itself but with the pattern it is tested against in
if (0 === strpos($pathinfo, '/%sub_dir%/secured/admin')) {

But I don't know how that string is created.

[DHorchler]

I found a workaraound:

in namespace Symfony\Component\Routing\Matcher\Dumper change line 141 from

$optimizable = '' !== $prefix && $prefix !== $parentPrefix && $countDirectChildRoutes > 0 && $countAllChildRoutes > 1 && false === strpos($prefix, '{');

to

$optimizable = false;//'' !== $prefix && $prefix !== $parentPrefix && $countDirectChildRoutes > 0 && $countAllChildRoutes > 1 && false === strpos($prefix, '{');

and it works.

[DHorchler]

ok, here's a possible patch:

first we need a setter for the RouteCollection prefix in Symfony\Component\Routing\RouteCollection like:

public function setPrefix($prefix)
{
    $this->prefix = $prefix;
}

Then in Symfony\Bundle\FrameworkBundle\Routing\Router add this line:

$collection->setPrefix('/'.ltrim($this->resolveString($collection->getPrefix()), '/'));

in function ResolveParameters like

private function resolveParameters(RouteCollection $collection)
{
    foreach ($collection as $route) {
        if ($route instanceof RouteCollection) {
            $this->resolveParameters($route);
        } else {
            foreach ($route->getDefaults() as $name => $value) {
                $route->setDefault($name, $this->resolveString($value));
            }

            foreach ($route->getRequirements() as $name => $value) {
                 $route->setRequirement($name, $this->resolveString($value));
            }
            $collection->setPrefix('/'.ltrim($this->resolveString($collection->getPrefix()), '/'));
            $route->setPattern($this->resolveString($route->getPattern()));
        }
    }
}

[rande]

@Tobion Can you reconsidere this issue ?
@2manypeople Can you propose a PR (with a test case) ?

Thanks

[Tobion]

I see this is for Symfony 2.1 only. It should be fixed in 2.2
@2manypeople please open a PR.

[DHorchler]

@Tobion yes, will need a couple of days.