Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony web debug bar with ie8 #7422

Closed
mlwacosmos opened this issue Mar 19, 2013 · 8 comments
Closed

Symfony web debug bar with ie8 #7422

mlwacosmos opened this issue Mar 19, 2013 · 8 comments

Comments

@mlwacosmos
Copy link

There is an issue concerning the web debug bar with version 2.1 and 2.2 of Symfony with IE8 browser... it is displayed good with 2.0 version but with the latest ones, the css is not loaded or it could be css3 (ie8 does not understand).

Consequence : the web debug bar is displayed without css (annoying)..

Note : no problem with other browsers like Firefox or Chrome of course

@stof
Copy link
Member

stof commented Mar 19, 2013

It is because IE8 does not support media queries.

@lazyhammer
Copy link
Contributor

@stof It is probably because IE8 ignores dynamically created style tags.

@fabpot
Copy link
Member

fabpot commented Mar 19, 2013

Closing as we won't support IE8 anyway. That's a developer tool and if I have a look at the symfony.com stats, IE (all versions) is less than 1%.

@fabpot fabpot closed this as completed Mar 19, 2013
@mlwacosmos
Copy link
Author

Ouah... well I think it is sad when you develop a framework to give up on some quite 'new' browsers... obviously the framework is used by developers who work in firms and IE is quite present in firms and not especially IE9. I works for Health Insurance in France and I am thinking of imposing the framework to our PHP staff. It is bad to say , we can only use the 2.0 version until we have IE9 (which will arrive in a long tim eas we just have IE8) because it has been decided to give up on some 'quite new browsers' which I dont think a framework should do. (I know we only talk about a web debug toolbar... but anyway..a Google-like strategy would have been better I think)

@stof
Copy link
Member

stof commented Mar 19, 2013

@mlwacosmos Actually, the fix to have the styles applying in IE8 is really easy (once we manage to find the page explaining the weird IE behavior). See the related PR.

@mvrhov
Copy link

mvrhov commented Mar 19, 2013

@mlwacosmos: Well the google supports the latest two browsers which in Microsoft's case are IE9 and IE10

fabpot added a commit that referenced this issue Mar 19, 2013
This PR was merged into the 2.2 branch.

Commits
-------

39445c5 [WebProfilerBundle] Fixed the toolbar styles to apply them in IE8

Discussion
----------

[WebProfilerBundle] Fixed the toolbar styles to apply them in IE8

| Q             | A
| ------------- | ---
| Fixed tickets | #7422
| License       | MIT

Currently, the toolbar breaks the design of the whole page in IE8 and lower as it does not have styles applied. Even though it is a debugging tool and devs are often using modern browsers, it is painful to be forced to disable it when testing the site in IE (I won't bother about supporting the profiler JS in IE8 though as this is a different page which can be displayed in a modern browser even when testing in IE).
The reason of the issue is that [IE8 removes style tags at the beginning when setting the innerHTML](http://social.msdn.microsoft.com/forums/en-US/iewebdevelopment/thread/33fd33f7-e857-4f6f-978e-fd486eba7174/). As the fix is as easy as moving the tag after the div, I don't see a reason to reject this change.

I sent the bugfix to 2.2 because these templates have been refactored a lot between 2.1 and 2.2 so the fix would have been different. However, it is also possible to fix it in 2.1 if you want.
@fabpot
Copy link
Member

fabpot commented Mar 19, 2013

The PR has been merged, so this issue has been fixed.

@mlwacosmos
Copy link
Author

@stof Thanks to you

ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants