Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Session target_path not set when the incoming request has no session #772

Closed
stof opened this issue May 4, 2011 · 1 comment
Closed

[Security] Session target_path not set when the incoming request has no session #772

stof opened this issue May 4, 2011 · 1 comment
Assignees
@schmittjoh
Labels
Bug Security

Comments

@stof
Copy link
Member

stof commented May 4, 2011

Symfony\Component\Security\Http\Firewall\ExceptionListener only sets the target path when $request->hasSession() is true. This is the wrong behavior IMO as it checks if there is a previous session instead of checking if the session is activated in the project (which would be done by checking null !== $request->getSession().
I open the issue as @schmittjoh asked it on IRC saying he needs to check further about this.
@ghost ghost assigned schmittjoh May 4, 2011
stof added a commit to stof/symfony that referenced this issue May 4, 2011
@stof
[Security] Check if the session is activated instead of checking if t…
c2ff5de 
…here is a session from a previous request. Fixes symfony#772
@schmittjoh
Copy link
Contributor

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schmittjoh schmittjoh

Labels
Bug Security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security] Fix for #772 stof/symfony
2 participants
@schmittjoh @stof