AccessDecisionManager does not validate the passed strategy

[denderello]

Right now the AccessDecisionManager does not validate the strategy passed via the constructor. Since the SecurityBundle is not validating the strategy either, users will end up in a fatal error when they pass a strategy name that cannot be converted to a corresponding decision method (e.g. with a typo).

You can easily reproduce this with the following configuration in your security.yml:

security:
    access_decision_manager:
            strategy:             fooBar

which will produce an exception like this on a Symfony based project:

Can we add a validation check for the passed strategy during the construction of AccessDecisionManager instances? I would volunteer to create a PR for this.

[stof]

@denderello I think adding a check is a good idea. Can you provide a PR ?

[denderello]

Sure. I will try to get one ready today. Otherwise I will have it ready
next week.

On Fri, Aug 9, 2013 at 11:51 AM, Christophe Coevoet <
notifications@github.com> wrote:

@denderello https://github.com/denderello I think adding a check is a
good idea. Can you provide a PR ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/8646#issuecomment-22385202
.

[denderello]

I think now that #8710 is merged this one can be closed, right?