[Translator] [FrameworkBundle] Translation loader - ignore locale #9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Padam87
changed the title
|
Fixed by the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TranslationLoader should ignore(or should have the option to ignore) locale when collecting keys from translation files. This would help identify missing translations, unecessary keys, and make the translation keys consistent.
My idea would be to create the message catalogue with null locale
$catalogue = new MessageCatalogue(null);. This would mark the cataloge as not locale aware, and it would only contain translation keys.What do you think?