Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] IcuResFileDumperTest::testDump can't rmdir #9475

Closed
andremaha opened this issue Nov 9, 2013 · 0 comments
Closed

[Tests] IcuResFileDumperTest::testDump can't rmdir #9475

andremaha opened this issue Nov 9, 2013 · 0 comments

Comments

@andremaha
Copy link
Contributor 

Symfony\Component\Translation\Tests\Dumper\IcuResFileDumperTest::testDump
rmdir(/var/folders/_9/qxn2vzt94sg07g5gj6dxt8q00000gn/T/messages): Directory not empty

/Users/andreyesaulov/symfony-patch/src/Symfony/Component/Translation/Tests/Dumper/IcuResFileDumperTest.php:35

The reason for this is that another test is creating Images folder inside of the directory, so that this test can't remove the parent directory, since it is not empty anymore.

Working on a patch right now.
andremaha added a commit to andremaha/symfony that referenced this issue Nov 9, 2013
@andremaha
[Translation] fixed the error in the dumper test as described in symf…
853404a 
…ony#9475
@andremaha andremaha mentioned this issue Nov 9, 2013
Merged
fabpot added a commit that referenced this issue Nov 9, 2013
@fabpot
minor #9477 [Translation] fixed the error in the dumper test as descr…
78e9acb 
…ibed in #9475 (andremaha)

This PR was merged into the 2.2 branch.

Discussion
----------

[Translation] fixed the error in the dumper test as described in #9475

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9475
| License       | MIT
| Doc PR        | -

Commits
-------

853404a [Translation] fixed the error in the dumper test as described in #9475
@fabpot fabpot closed this as completed Nov 9, 2013
fabpot added a commit that referenced this issue Nov 13, 2013
@fabpot
Merge branch '2.2' into 2.3
59a4313 
* 2.2:
  bumped Symfony version to 2.2.11
  updated VERSION for 2.2.10
  update CONTRIBUTORS for 2.2.10
  updated CHANGELOG for 2.2.10
  fixed version
  Request::overrideGlobals() may call invalid ini value
  Force Luhn Validator to only work with strings
  [Translation] fixed the error in the dumper test as described in #9475
  [Console] fix phpdoc and constructor default value

Conflicts:
	src/Symfony/Component/Console/Helper/ProgressHelper.php
	src/Symfony/Component/HttpKernel/Kernel.php
fabpot added a commit that referenced this issue Nov 13, 2013
@fabpot
Merge branch '2.3'
587f355 
* 2.3: (25 commits)
  bumped Symfony version to 2.2.11
  updated VERSION for 2.2.10
  update CONTRIBUTORS for 2.2.10
  updated CHANGELOG for 2.2.10
  fixed version
  Request::overrideGlobals() may call invalid ini value
  Force Luhn Validator to only work with strings
  Fixed bug with lazy services
  [Translation] fixed the error in the dumper test as described in #9475
  deleted mixing string concatenation inside a sprintf
  "__call()" should be displayed only if $this->magicCall is true
  [Console] fix phpdoc and constructor default value
  Add media-query for printing: Do not print the toolbar.
  Fix ProgressHelper redraw when redrawFreq is greater than 1
  Update toolbar.css.twig
  slovenian translations fixed
  slovenian translations fixed
  [DependencyInjection] fixed YamlDumper did not make services private.
  [FrameworkBundle] fix routing container parameter exception message
  [Form] fix and unify phpdoc
  ...

Conflicts:
	src/Symfony/Component/Console/Helper/ProgressHelper.php
	src/Symfony/Component/DependencyInjection/ContainerBuilder.php
	src/Symfony/Component/HttpKernel/Kernel.php
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
@fabpot
Merge branch '2.3'
f5f6285 
* 2.3: (25 commits)
  bumped Symfony version to 2.2.11
  updated VERSION for 2.2.10
  update CONTRIBUTORS for 2.2.10
  updated CHANGELOG for 2.2.10
  fixed version
  Request::overrideGlobals() may call invalid ini value
  Force Luhn Validator to only work with strings
  Fixed bug with lazy services
  [Translation] fixed the error in the dumper test as described in symfony#9475
  deleted mixing string concatenation inside a sprintf
  "__call()" should be displayed only if $this->magicCall is true
  [Console] fix phpdoc and constructor default value
  Add media-query for printing: Do not print the toolbar.
  Fix ProgressHelper redraw when redrawFreq is greater than 1
  Update toolbar.css.twig
  slovenian translations fixed
  slovenian translations fixed
  [DependencyInjection] fixed YamlDumper did not make services private.
  [FrameworkBundle] fix routing container parameter exception message
  [Form] fix and unify phpdoc
  ...

Conflicts:
	src/Symfony/Component/Console/Helper/ProgressHelper.php
	src/Symfony/Component/DependencyInjection/ContainerBuilder.php
	src/Symfony/Component/HttpKernel/Kernel.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @andremaha