[Form] Added check for parent disabled status in Button form elements #10110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Button form element did not check for the parent disabled configuration status, making them behave differently to all other form widgets.
|
Would be great if this could be merged... |
|
@yakobe I agree. |
|
Thanks for that PR! I added a test case in #10591. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Button form element did not check for the parent disabled configuration status,
making them behave differently to all other form widgets.
This is specially visible in the situation of a top-level Form element being Disabled, which would disable all children widgets except the Buttons (and Submit buttons).
This patch simply ports the code from the base
Form.phpmethod in order to make the behaviour exactly the same.Further action would include