[SecurityBundle] Use RequestStack instead of full Container in LogoutUrlHelper #10250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stloyd
commented
Feb 12, 2014
stloyd
commented
| Q | A |
|---|---|
| Bug fix? | kinda |
| New feature? | no |
| BC breaks? | kinda(?) |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10249 (this PR is an alternative approach) |
| License | MIT |
|
It is a bc break obviously. But I agree injecting the container is not so nice and not needed anymore. |
|
@Tobion Yeah, you are probably right, but BC break is mostly because of the broken request management before |
|
Bc break is the changed constructor. |
|
That's why I didn't make this change in #10249 |
|
Closing as it breaks BC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.