New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC][WebProfilerBundle] Add simple placeholders into search form #10660
Conversation
@stloyd thanks for this pull request. I really like it! The only thing that I'm not sure about is the date placeholders. You propose to use the following: <input type="text" name="start" id="start" value="{{ start }}"
placeholder="i.e. {{ '-2days'|date('d.m.Y') }}">
{# ... #}
<input type="text" name="end" id="end" value="{{ end }}"
placeholder="i.e. {{ 'now'|date('d.m.Y') }}"> In my opinion, using dynamic dates is handy but not always helpful. The problem with dates is that you never know if the first number is the day or the month. Take for example your screenshot: I'm not sure about this but, do you think it could be better to replace the dynamic dates for date format placeholderes such as |
@@ -5,7 +5,7 @@ | |||
</h3> | |||
<form action="{{ path('_profiler_search') }}" method="get"> | |||
<label for="ip">IP</label> | |||
<input type="text" name="ip" id="ip" value="{{ ip }}"> | |||
<input type="text" name="ip" id="ip" value="{{ ip }}" placeholder="i.e. 127.0.0.1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean "e.g." not "i.e."
@javiereguiluz Really good point, and I must say that I was not sure what to put there, so I choose most common format I know =) But taking your point I think that this version: |
A placeholder like |
As Javier proposed, I'm much more in favor of using |
👍 for date input |
Using a date input as suggested by @pborreli makes a lot of sense as all browsers used by developers probably support this anyway. |
@stloyd Can you update this PR? |
@fabpot Done, unfortunately we can't use only |
Thank you @stloyd. |
…search form (stloyd) This PR was merged into the 2.6-dev branch. Discussion ---------- [RFC][WebProfilerBundle] Add simple placeholders into search form This is an RFC mostly, it's not a real feature, it's more like little helper for the profiler form, I guess that would mostly useful for _newcomers_, but sometimes even _old dogs_ could find it useful sometimes =) | Q | A | ------------- | --- | Bug fix? | no | New feature? | kinda | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT ![form](https://cloud.githubusercontent.com/assets/67402/2655386/4637aa0c-bfe5-11e3-958e-84308217b52e.png) Commits ------- be65226 [WebProfilerBundle] Add simple placeholders into search form
This is an RFC mostly, it's not a real feature, it's more like little helper for the profiler form, I guess that would mostly useful for newcomers, but sometimes even old dogs could find it useful sometimes =)