[Console] Fix #10795: Allow instancing Console Application when STDIN is not declared #10798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romainneutron
commented
Apr 28, 2014
romainneutron
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10795 |
| License | MIT |
…n STDIN is not declared
|
Thanks for fixing this bug @romainneutron. |
fabpot
added a commit
that referenced
this pull request
Apr 28, 2014
… when STDIN is not declared (romainneutron) This PR was merged into the 2.5-dev branch. Discussion ---------- [Console] Fix #10795: Allow instancing Console Application when STDIN is not declared | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10795 | License | MIT Commits ------- 3a5a525 [Console] Fix #10795: Allow instancing Console Application when STDIN is not declared
fabpot
added a commit
that referenced
this pull request
Jun 8, 2020
…efined (xabbuh) This PR was merged into the 5.1 branch. Discussion ---------- [Console] allow cursor to be used even when STDIN is not defined | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37124 | License | MIT | Doc PR | This allows to use the `Cursor` class introduced in Symfony 5.1 even when the `STDIN` constant is not defined. We did a similar bugfix in the past in the `QuestionHelper` class in #10798. Commits ------- aff1ffa allow cursor to be used even when STDIN is not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.