[FrameworkBundle] container:debug : list services if no service match exacly the name argument #11339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $helper = $this->getApplication()->getHelperSet()->get('question'); | ||
| $question = new ChoiceQuestion( | ||
| 'Choose a number for more information on the service', | ||
| $this->findServiceidsLike($builder, $name) |
There was a problem hiding this comment.
Should be findServiceIdsLike (capital I)
| @@ -116,6 +118,10 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $options['format'] = $input->getOption('format'); | |||
| $options['raw_text'] = $input->getOption('raw'); | |||
| $helper->describe($output, $object, $options); | |||
|
|
|||
| if (!$input->getArgument('name') && $input->isInteractive()) { | |||
There was a problem hiding this comment.
Looks like the indentation of this block is wrong.
agallou
force-pushed
the
container_debug_search_services
branch
from
ce1acd3
to
7f866c3
Compare
| return $name; | ||
| } | ||
|
|
||
| $helper = $this->getApplication()->getHelperSet()->get('question'); |
There was a problem hiding this comment.
This can just be $this->getHelper('question');
|
I like the approach! It's even easier than I was imagining because it doesn't make you re-run the command to find out more about the service you might be looking for. |
|
|
||
| private function findProperServiceName(InputInterface $input, OutputInterface $output, ContainerBuilder $builder, $name) | ||
| { | ||
| if ($builder->has($name)) { |
There was a problem hiding this comment.
you should also return early in case the input is not interactive (or you need to set $name as the default in your Question)
agallou
force-pushed
the
container_debug_search_services
branch
from
7f866c3
to
22f7151
Compare
|
FYI - The PR has been updated after Stof's comment. |
| $serviceIds = $builder->getServiceIds(); | ||
| $foundServiceIds = array(); | ||
| foreach ($serviceIds as $serviceId) { | ||
| if (false === strpos($serviceId, $name)) { |
There was a problem hiding this comment.
given that service ids are always lowercase internally in Symfony, you should either use stripos, or even better lowercase $name (which can be done outside the loop)
… exacly the name argument | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11303 | License | MIT | Doc PR | If we launch the command "container:debug log" and there is no service nammed log, it will print something like this : ``` [0] logger [1] monolog.handler.console [2] monolog.handler.debug ``` After the service has been chosen, usual container:debug informations are displayed.
agallou
force-pushed
the
container_debug_search_services
branch
from
22f7151
to
16201b6
Compare
|
I've updated the PR to lowercase the searched service name according to @stof comment |
|
Thank you @agallou. |
fabpot
added a commit
that referenced
this pull request
Oct 2, 2014
…o service match exacly the name argument (agallou) This PR was merged into the 2.6-dev branch. Discussion ---------- [FrameworkBundle] container:debug : list services if no service match exacly the name argument | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11303 | License | MIT | Doc PR | If we launch the command "container:debug log" and there is no service nammed log, it will print something like this : ``` [0] logger [1] monolog.handler.console [2] monolog.handler.debug ``` After the service has been chosen, usual container:debug informations are displayed. Commits ------- 16201b6 [FrameworkBundle] container:debug : list services if no service match exacly the name argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we launch the command "container:debug log" and there is no
service nammed log, it will print something like this :
After the service has been chosen, usual container:debug informations
are displayed.