Improve the exception message of UrlMatcher #11767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,7 +93,7 @@ public function match($pathinfo) | |||
|
|
|||
| throw 0 < count($this->allow) | |||
| ? new MethodNotAllowedException(array_unique(array_map('strtoupper', $this->allow))) | |||
| : new ResourceNotFoundException(); | |||
| : new ResourceNotFoundException("No routes found for $pathinfo"); | |||
There was a problem hiding this comment.
building the exception message should use sprintf rather than interpolation
|
meh |
| @@ -93,7 +93,7 @@ public function match($pathinfo) | |||
|
|
|||
| throw 0 < count($this->allow) | |||
| ? new MethodNotAllowedException(array_unique(array_map('strtoupper', $this->allow))) | |||
| : new ResourceNotFoundException(); | |||
| : new ResourceNotFoundException(sprintf('No routes found for %s', $pathinfo)); | |||
There was a problem hiding this comment.
All our error messages should end with a dot.
|
why cloding it ? |
|
What means cloding? http://www.dict.cc/?s=cloding |
|
closing* |
|
Ehem, I am primarily stupid. |
|
👍 |
| @@ -93,7 +93,7 @@ public function match($pathinfo) | |||
|
|
|||
| throw 0 < count($this->allow) | |||
| ? new MethodNotAllowedException(array_unique(array_map('strtoupper', $this->allow))) | |||
| : new ResourceNotFoundException(); | |||
| : new ResourceNotFoundException(sprintf('No routes found for %s.', $pathinfo)); | |||
There was a problem hiding this comment.
What about enclosing the value in double quotes?
There was a problem hiding this comment.
oops, I saw your message after merging this PR. I fixed the double-quotes in df244f2
|
👍 |
|
Thank you @dawehner. |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- Improve the exception message of UrlMatcher The current exception message is not optimal, some more context always helps. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- ee1197d Improve the exception message in the UrlMatcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current exception message is not optimal, some more context always helps.