Reverse DateTimeToStringTransformer must use format #1183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $last_errors = \DateTime::getLastErrors(); | ||
| if($last_errors['warning_count'] > 0 || $last_errors['error_count'] > 0){ | ||
| throw new \Exception('Date is invalid.'); | ||
| } |
There was a problem hiding this comment.
IMO better would be something like:
$errors = \DateTime::getLastErrors();
if ($errors['warning_count'] > 0) {
throw new \Exception(current($errors['warning']));
} else if ($errors['error_count'] > 0) {
throw new \Exception(current($errors['error']));
}
There was a problem hiding this comment.
Return only the first warning / error ?
Return only errors (and not warnings) if there are errors and warnings?
There was a problem hiding this comment.
It's proposal ;-) and still is better then you first approach :-)
$errors = \DateTime::getLastErrors();
if ($errors['warning_count'] > 0 || $errors['error_count'] > 0) {
if ($errors['warning_count'] > 0) {
throw new \Exception('Date is invalid. List of warnings: "' . implode(', "', array_values($errors['warning'])) . '"');
}
if ($errors['error_count'] > 0) {
throw new \Exception('Date is invalid. List of errors: "' . implode(', "', array_values($errors['error'])) . '"');
}
}
Remember it's only proposal ;-)
|
The code is updated. Thanks stloyd :) |
|
Tests do not pass for me after applying this patch: |
|
It's strange because tests pass for me :/ (with last commit 2d91183) : phpunit tests/Symfony/Tests/Component/Form/Extension/Core/Type/DateTypeTest
PHPUnit 3.5.13 by Sebastian Bergmann.
..........IIIIIIIIIIIIIIII...
Time: 1 second, Memory: 6.75Mb
?[30;43m?[2KOK, but incomplete or skipped tests!
?[0m?[30;43m?[2KTests: 29, Assertions: 46, Incomplete: 16.
?[0m?[2KOther persons have this problem? |
stloyd
added a commit
to stloyd/symfony
that referenced
this pull request
Jun 30, 2011
* TimeType: - seconds are no longer populated if "with_seconds" = false - "widget = text" is now properly rendered (closes symfony#1480) * DateTimeToStringTransformer: - fixed using not default "format" (probably fix symfony#1183) * DateType, DateTimeType, TimeType: - fixed "input = datetime" and test covered - a bit changed readability
|
@hlecorche Please check PR #1485. Should fix your issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of pull request #1134 (I am sorry, the old pull request has been deleted because I deleted one commit which was in a bad branch).
Summary:
Before: In DateTimeToStringTransformer, transform function uses "format" but not "reverseTransform".
If the format is different than "Y-m-d", reverseTransform throws TransformationFailedException.
Now: "reverse" function uses "format". I added "\DateTime::getLastErrors()" because DateTime::createFromFormat doesn't throw exception.
Now, if a bad date (2011-02-29) is given, it is refused.
I added additional tests.