Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] CSRF warning docs on Request::enableHttpMethodParameterOverride() #12168

Merged
merged 1 commit into from Nov 2, 2014
Merged

[HttpFoundation] CSRF warning docs on Request::enableHttpMethodParameterOverride() #12168

merged 1 commit into from Nov 2, 2014

Conversation

kristofvc
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #12043
License MIT
Doc PR /

Since I wanted to understand this issue I did some research and altered the comment block. Is this a clear enough explanation or does it need more?

[HttpFoundation] fixed the docs so that it gives some explanation about how you are vulnerable to CSRF when you enable the httpMethodeParameterOverride
@kristofvc kristofvc changed the title CSRF warning docs on Request::enableHttpMethodParameterOverride() [HttpFoundation] CSRF warning docs on Request::enableHttpMethodParameterOverride() Oct 8, 2014
@fabpot
Copy link
Member

fabpot commented Nov 2, 2014

Thank you @kristofvc.

@fabpot fabpot merged commit deb70ab into symfony:2.3 Nov 2, 2014
fabpot added a commit that referenced this pull request Nov 2, 2014
…pMethodParameterOverride() (Kristof Van Cauwenbergh)

This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] CSRF warning docs on Request::enableHttpMethodParameterOverride()

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12043
| License       | MIT
| Doc PR        | /

Since I wanted to understand this issue I did some research and altered the comment block. Is this a clear enough explanation or does it need more?

Commits
-------

deb70ab CSRF warning docs on Request::enableHttpMethodParameterOverride()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants