[Config] fix filelocator with empty name #12206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
changed the title
Tobion
changed the title
Tobion
force-pushed
the
config-loader
branch
2 times, most recently
from
dea509e
to
f1dba8a
Compare
| * @param mixed $resource The resource | ||
| * @param string|null $type The resource type or null if unknown | ||
| * | ||
| * @throws FileLoaderLoadException If something went wrong |
There was a problem hiding this comment.
this is wrong. Other loaders than the FileLoader won't use the FileLoaderLoadException but any exception (the FileLoader is wrapping exceptions in a FileLoaderLoadException to add the info about which file is being loaded)
|
@fabpot this mostly fixes phpdoc and should be easy to merge. |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Oct 30, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Config] fix filelocator with empty name | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - fix filelocator with empty name + phpdoc in config component Commits ------- 63b8c07 [DependencyInjection] use inheritdoc for loaders ddd2fe2 [Config] fix filelocator with empty name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix filelocator with empty name + phpdoc in config component