Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners #12296

Closed
wants to merge 2 commits into from
Closed

[SecurityBundle] Authentication entry point is only registered with firewall exception listener, not with authentication listeners #12296

wants to merge 2 commits into from

Commits on Nov 5, 2014

  1. Prove that custom entry point isn't started with unknown credentials.

    Reinier Kip committed Nov 5, 2014
    Copy the full SHA
    eeaf21b View commit details
    Browse the repository at this point in the history

  2. Ensure the configured entry point is used in the auth listeners 

    I had configured a different firewall entry point for one
firewall. However, when authentication had to be performed, it
still called BasicAuthenticationEntryPoint::start() instead of my
service's start(). My service was instantiated, yet never used.

The issue appeared to be that the entry point is registered with
the firewall's exception listener, but not with the
BasicAuthenticationListener. This means that when the
BasicAuthenticationListener determines the user has provided wrong
credentials, BasicAuthenticationEntryPoint is still used. Only in
case of an exception would my entry point service be used.

See #12261.
    Reinier Kip committed Nov 5, 2014
    Copy the full SHA
    32dec85 View commit details
    Browse the repository at this point in the history