Issue #12658 Add a deprecation note about Translator's setFallbackLocale... #12671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
javiernuber
commented
Nov 29, 2014
javiernuber
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12658 |
| License | MIT |
| Doc PR |
…backLocale method
| @@ -160,6 +160,7 @@ public function getLocale() | |||
| */ | |||
| public function setFallbackLocale($locales) | |||
| { | |||
| trigger_error('The setFallbackLocale method was removed in 3.0. You should use the new method setFallbackLocales.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
This should rather read like "The setFallbackLocale() method is deprecated since version 2.6 and will be removed in 3.0. Use setFallbackLocales() instead." (see http://symfony.com/doc/current/contributing/code/conventions.html#deprecations). You will probably have to change 2.6 to the version number where the setFallbackLocales() method was introduced.
…backLocale method
| * | ||
| * @api | ||
| */ | ||
| public function setFallbackLocale($locales) | ||
| { | ||
| trigger_error( | ||
| 'The setFallbackLocale() method is deprecated since version 2.3 and will be removed in 3.0. Use setFallbackLocales() instead.', |
There was a problem hiding this comment.
Can you move the whole expression on one line? Thanks.
|
Thank you @javiernuber. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.