[Form] Fixed check of violation constraint #12792 #13198
Conversation
|
Please provide a test case |
|
tests added |
|
ping @webmozart |
| @@ -66,7 +66,7 @@ protected function setUp() | |||
|
|
|||
| private function getConstraintViolation($code = null) | |||
| { | |||
| return new ConstraintViolation($this->message, $this->messageTemplate, $this->params, null, 'prop.path', null, null, $code, new Form()); | |||
| return $this->getMock('Symfony\Component\Validator\ConstraintViolation', array('getConstraint'), array($this->message, $this->messageTemplate, $this->params, null, 'prop.path', null, null, $code)); | |||
There was a problem hiding this comment.
no need to use a mock IMO. Just add an argument in the getter to decide whether the last argument should be the constraint or null
There was a problem hiding this comment.
this was my first step. Than I realized that it is probably a good idea to test, if getConstraint is called by validateForm. Otherwise it could be simply removed without breaking the tests (which would also fix the bug). So I changed it to build a mock and added $violation->expects($this->atLeastOnce())->method('getConstraint') to the test cases.
There was a problem hiding this comment.
if getConstraint is not called, then other tests should fail. don't mix both things.
ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)
|
As @Tobion said, I have changed the commit so that it is discrete and only test the particular case. |
|
👍 |
|
Thank you @xelaris. |
This PR was merged into the 2.6 branch. Discussion ---------- [Form] Fixed check of violation constraint #12792 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12792 | License | MIT | Doc PR | ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0) Commits ------- aedabc7 [Form] Fixed check of violation constraint #12792
…hDude) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Removed legacy check in `ValidationListener` | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | ~ | License | MIT | Doc PR | ~ A left over of #13198, should have been removed in 3.0. The tests don't use `null` anymore, no update needed here, this is just about removing dead code. Commits ------- e479e51 [Form] Removed legacy check in `ValidationListener`
ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)