[Var-Dumper] Fixed encoding issue

[arrilot]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	no
Fixed tickets	-
License	MIT
Doc PR	-

Not ready yet. I need to change implementation first because this one is not working well enough

When I started using symfony/var-dumper in non-Symfony app i ran across the following encoding issue:

Applications files are in windows-1251 encoding,
Everything in browser output is OK except the var-dumper output which is broken:

After this fix, as soon as somewhere in bootstrap mb_detect_order is set as needed, we get the correct output:

Windows-1252 is explicitly added to the array of available encodings only for BC.

Please correct me I'm wrong

[fabpot]

ping @nicolas-grekas

[nicolas-grekas]

Thanks for reporting the issue @arrilot . The fix your propose is not reliable enough imho. I'm currently trying to find the best way to properly handle charset issues.

[nicolas-grekas]

@arrilot can you please try #13441? Note that you may have to set php.ini default_charset to CP1251 or explicitly set a second $charset argument when instanciating HtmlDumper.

[arrilot]

@nicolas-grekas Yeah, I was going to find another solution after i reaIized that mb_detect_encoding is worthless in this case.
Nice to see that you have already done all the work instead of me, thanks
I've tried your PR in my cp1251-app and everything seems ok. 👍

One more thing to note:
I haven't checked it, but i think that the "not-mbstring" part of AbstractDumper::utf8Encode() won't work well with encodings different from utf-8 and cp1252. I don't even know if it is worth supporting or not.

[fabpot]

closing in favor of #13441