[HttpKernel] Make WebTestCase::createClient() method throw an Exception i #1351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on instead of being declared abstract. Since PHP 5.3, a Strict Standards notice is raised if a method is declared both static and abstract.
|
I would rather just remove this class. |
|
removed in #1352 |
|
merged #1352 instead. |
fabpot
added a commit
to symfony/form
that referenced
this pull request
Nov 25, 2013
Commits ------- f08533f [HttpKernel] Remove useless WebTestCase class Discussion ---------- [HttpKernel] Remove useless WebTestCase class see symfony/symfony#1351
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[HttpKernel] Make WebTestCase::createClient() method throw an Exception instead of being declared abstract. Since PHP 5.3, a Strict Standards notice is raised if a method is declared both static and abstract.