Removed deprecations in Console component #14118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saro0h
commented
Mar 30, 2015
saro0h
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | no |
| License | MIT |
| Doc PR | ~ |
| @@ -52,7 +52,8 @@ public function testLegacyInputOptionDefinitionInConstructor() | |||
| array(new InputOption('foo', null, InputOption::VALUE_REQUIRED)) | |||
| ); | |||
|
|
|||
| $input = new StringInput('--foo=bar', $definition); | |||
| $input = new StringInput('--foo=bar'); | |||
| $input->bind($definition); | |||
There was a problem hiding this comment.
You can remove the whole test (it's the same as testInputOptionWithGivenString above now).
saro0h
force-pushed
the
deprecation-console
branch
from
f8d9da2
to
465bf6a
Compare
saro0h
force-pushed
the
deprecation-console
branch
from
465bf6a
to
1a8f87d
Compare
|
Thank you @saro0h. |
fabpot
added a commit
that referenced
this pull request
Mar 31, 2015
This PR was merged into the 3.0-dev branch. Discussion ---------- Removed deprecations in Console component | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | ~ Commits ------- 1a8f87d Removed deprecations in Console component
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.