[StringUtil] Fixed singularification of 'selfies' #14452
Conversation
|
@pmodin thanks for fixing this problem. As you know, languages designed for humans are a fractal of bad design and they are plagued with exceptions. That's why some of us want to remove the "magic pluralizator" implemented by Symfony. Hopefully getting more and more issue reports and pull requests for this feature will also make the other developers change their opinion about this. |
|
@javiereguiluz yes, I've seen some discussions about this, most recently in #14189. I haven't been in the loop enough recently to argue on how to progress, but you, as well as the others, do have valid points. I unfortunately have nothing further to add to that discussion right now. |
|
@javiereguiluz I agree with you, but don't know what more I could do a.t.m. 😒 |
|
@javiereguiluz until we find a way to provide explicitly the singular names for the adder and remover methods (see #5013 for the discussion about that) , we cannot drop the existing singularization (you will see even more complains if you ask people to define |
| @@ -60,6 +60,9 @@ class StringUtil | |||
| // indices (index), appendices (appendix), prices (price) | |||
| array('seci', 4, false, true, array('ex', 'ix', 'ice')), | |||
|
|
|||
| // selfies (selfie) | |||
| array('seifles', 7, true, true, 'selfie'), | |||
There was a problem hiding this comment.
I admit that it looks very weird, but in this class those words are spelled backwards. So it's "correct" to use seifles here.
|
Thank you @pmodin. |
This PR was merged into the 2.3 branch. Discussion ---------- [StringUtil] Fixed singularification of 'selfies' | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Related to #14191. At tonights PHP Stockholm meetup we discussed #14191, and we noticed that "selfie" was incorrectly handled as well. One selfie, many selfies. Commits ------- 7c2b875 [StringUtil] Fixed singularification of 'selfies'
Related to #14191.
At tonights PHP Stockholm meetup we discussed #14191, and we noticed that "selfie" was incorrectly handled as well. One selfie, many selfies.