[WebProfiler] fix html syntax for input types #14466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tobion please use your fork to send PRs, not the symfony repo. This avoids creating useless versions of Packagist (and also avoids triggering 2 Travis builds, for the branch and for the PR) |
|
Yes was by accident. |
|
Looks like it should be merged in 2.6 instead, right? |
|
Yes should be mergeable in 2.6 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Apr 27, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.6 branch instead (closes #14466). Discussion ---------- [WebProfiler] fix html syntax for input types | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - HTML validator: > Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url. > Element option without attribute label must not be empty. The other placeholders are totatlly useless. For url it usually just says `e.g.` without a value because the baseUrl is empty... Commits ------- 876b180 [WebProfiler] fix html syntax for input types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML validator:
The other placeholders are totatlly useless. For url it usually just says
e.g.without a value because the baseUrl is empty...