[TwigBundle] Fix deprecated use of FlattenException #14480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alOneh
commented
Apr 27, 2015
alOneh
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
alOneh
force-pushed
the
preview-error-controller-deprecated-flatten-exception
branch
from
850d734
to
10612b0
Compare
| @@ -12,7 +12,7 @@ | |||
| namespace Symfony\Bundle\TwigBundle\Controller; | |||
|
|
|||
| use Symfony\Bundle\FrameworkBundle\Templating\TemplateReference; | |||
| use Symfony\Component\HttpKernel\Exception\FlattenException; | |||
| use Symfony\Component\Debug\Exception\FlattenException; | |||
alOneh
force-pushed
the
preview-error-controller-deprecated-flatten-exception
branch
from
10612b0
to
4d2f044
Compare
|
Reverted the BC break |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @alOneh. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 28, 2015
This PR was merged into the 2.6 branch. Discussion ---------- [TwigBundle] Fix deprecated use of FlattenException | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 4d2f044 [TwigBundle] Fix deprecated use of FlattenException
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Apr 28, 2015
Since symfony#14480, we use the `FlattenException` from the Debug component instead of the deprecated one from the HttpKernel component.
|
@philgagnon12 That was not possible to not break backward compatibility (otherwise old exceptions not extending the one from the Debug component would not have been able to be dealt with). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.