[DependencyInjection][3.0] Add initialized to container interface #15347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
znerol
commented
Jul 23, 2015
znerol
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #15346 |
| License | MIT |
| Doc PR | - |
|
This is a BC break, isn't it? As people typehinting for the new interface will have to update their code for Symfony 3.0 |
|
Yes, it is a BC, everyone who hast implemented |
|
Why not make a separate optional interface? |
|
@hhamon thats, what it was before...or i don't understand what you mean |
|
@fabpot thanks for the link, I didn't know there was a discussion about it. |
znerol
force-pushed
the
task/master/add-initialized-to-container-interface
branch
from
4e2f183
to
48a277d
Compare
|
👍 |
znerol
force-pushed
the
task/master/add-initialized-to-container-interface
branch
from
48a277d
to
bfddac3
Compare
|
Last commit resolves merge conflicts due to the recent introduction of |
|
👍 |
|
Thank you @znerol. |
fabpot
added a commit
that referenced
this pull request
Jul 26, 2015
…r interface (znerol) This PR was merged into the 3.0-dev branch. Discussion ---------- [DependencyInjection][3.0] Add initialized to container interface | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15346 | License | MIT | Doc PR | - Commits ------- bfddac3 [DependencyInjection] Add initialized() to the ContainerInterface
|
@fabpot should ResettableContainerInterface stay a separate interface in 3.0 or no ? |
|
@stof I think it should not. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.