Add appveyor.yml for C.I. on Windows #15575
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,4 @@ phpunit.xml | |
| composer.phar | ||
| package.tar | ||
| /packages.json | ||
| /.phpunit | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| build: false | ||
| shallow_clone: true | ||
| platform: x86 | ||
| clone_folder: c:\projects\symfony | ||
|
|
||
| environment: | ||
| matrix: | ||
| - PHP_EXT: 1 | ||
| - PHP_EXT: 0 | ||
|
|
||
| cache: | ||
| - c:\php -> appveyor.yml | ||
| - .phpunit -> phpunit | ||
| - vendor -> composer.json | ||
|
|
||
| init: | ||
| - SET PATH=c:\php;%PATH% | ||
| - SET COMPOSER_NO_INTERACTION=1 | ||
| - SET SYMFONY_DEPRECATIONS_HELPER=weak | ||
| - SET PHP=1 | ||
|
|
||
| install: | ||
| - IF EXIST c:\php (SET PHP=0) ELSE (mkdir c:\php) | ||
| - cd c:\php | ||
| - IF %PHP%==1 appveyor DownloadFile http://windows.php.net/downloads/releases/archives/php-5.4.43-nts-Win32-VC9-x86.zip | ||
|
There was a problem hiding this comment. @nicolas-grekas why testing against PHP 5.4 which is nearly EOL rather than against PHP 5.6 ? There was a problem hiding this comment. because I couldn't find a .dll for intl + icu 51.2 for 5.5 (vc9-nts-x86) |
||
| - IF %PHP%==1 7z x php-5.4.43-nts-Win32-VC9-x86.zip -y > 7z.log | ||
| - IF %PHP%==1 appveyor DownloadFile http://nebm.ist.utl.pt/~glopes/misc/intl_win/ICU-51.2-dlls.zip | ||
| - IF %PHP%==1 7z x ICU-51.2-dlls.zip -y > 7z.log | ||
| - IF %PHP%==1 cd ext | ||
| - IF %PHP%==1 appveyor DownloadFile http://nebm.ist.utl.pt/~glopes/misc/intl_win/php_intl-3.0.0-5.4-nts-vc9-x86.zip | ||
| - IF %PHP%==1 7z x php_intl-3.0.0-5.4-nts-vc9-x86.zip -y > 7z.log | ||
| - IF %PHP%==1 appveyor DownloadFile http://windows.php.net/downloads/pecl/releases/apc/3.1.13/php_apc-3.1.13-5.4-nts-vc9-x86.zip | ||
| - IF %PHP%==1 7z x php_apc-3.1.13-5.4-nts-vc9-x86.zip -y > 7z.log | ||
| - IF %PHP%==1 cd .. | ||
| - IF %PHP%==1 echo @php %%~dp0composer.phar %%* > composer.bat | ||
| - appveyor DownloadFile https://getcomposer.org/composer.phar | ||
| - copy php.ini-production php.ini /Y | ||
| - echo date.timezone="UTC" >> php.ini | ||
| - echo extension_dir=ext >> php.ini | ||
| - echo extension=php_openssl.dll >> php.ini | ||
| - IF %PHP_EXT%==1 echo extension=php_apc.dll >> php.ini | ||
| - IF %PHP_EXT%==1 echo extension=php_intl.dll >> php.ini | ||
| - IF %PHP_EXT%==1 echo extension=php_mbstring.dll >> php.ini | ||
| - IF %PHP_EXT%==1 echo extension=php_fileinfo.dll >> php.ini | ||
| - IF %PHP_EXT%==1 echo extension=php_pdo_sqlite.dll >> php.ini | ||
| - cd c:\projects\symfony | ||
| - php phpunit install | ||
| - IF %APPVEYOR_REPO_BRANCH%==master (SET COMPOSER_ROOT_VERSION=dev-master) ELSE (SET COMPOSER_ROOT_VERSION=%APPVEYOR_REPO_BRANCH%.x-dev) | ||
| - composer update --prefer-dist --no-progress --ansi | ||
|
|
||
| test_script: | ||
| - cd c:\projects\symfony | ||
| - php phpunit symfony --exclude-group benchmark,intl-data | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| #!/usr/bin/env php | ||
| <?php | ||
|
|
||
| error_reporting(-1); | ||
|
|
||
| $PHPUNIT_VERSION = 4.8; | ||
| $PHPUNIT_DIR = __DIR__.'/.phpunit'; | ||
|
|
||
| if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit")) { | ||
| # Build a standalone phpunit without symfony/yaml | ||
|
|
||
| $oldPwd = getcwd(); | ||
| mkdir($PHPUNIT_DIR); | ||
| chdir($PHPUNIT_DIR); | ||
| if (extension_loaded('openssl') && ini_get('allow_url_fopen')) { | ||
| stream_copy_to_stream(fopen("https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip", 'rb'), fopen("$PHPUNIT_VERSION.zip", 'wb')); | ||
| } else { | ||
| passthru("wget https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip"); | ||
| } | ||
| $zip = new ZipArchive(); | ||
| $zip->open("$PHPUNIT_VERSION.zip"); | ||
| $zip->extractTo(getcwd()); | ||
| $zip->close(); | ||
| chdir("phpunit-$PHPUNIT_VERSION"); | ||
| passthru("composer remove --no-update symfony/yaml"); | ||
| passthru("composer install --prefer-source --no-progress --ansi"); | ||
| chdir($oldPwd); | ||
| } | ||
|
|
||
| $cmd = array_map('escapeshellarg', $argv); | ||
| $exit = 0; | ||
|
|
||
| if (isset($argv[1]) && 'symfony' === $argv[1]) { | ||
| # Find Symfony components in plain php for Windows portability | ||
|
|
||
| $finder = new RecursiveDirectoryIterator('src/Symfony', FilesystemIterator::KEY_AS_FILENAME | FilesystemIterator::UNIX_PATHS); | ||
| $finder = new RecursiveIteratorIterator($finder); | ||
| $finder->setMaxDepth(3); | ||
|
|
||
| array_shift($cmd); | ||
| $cmd[0] = "php $PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit --colors=always"; | ||
| $procs = array(); | ||
|
|
||
| foreach ($finder as $file => $fileInfo) { | ||
| if ('phpunit.xml.dist' === $file) { | ||
| $component = dirname($fileInfo->getPathname()); | ||
|
|
||
| # Run phpunit tests in parallel | ||
|
|
||
| $c = escapeshellarg($component); | ||
|
|
||
| if ($proc = proc_open(implode(' ', $cmd)." $c > $c/phpunit.stdout 2> $c/phpunit.stderr", array(), $pipes)) { | ||
| $procs[$component] = $proc; | ||
| } else { | ||
| $exit = 1; | ||
| echo "\033[41mKO\033[0m $component\n\n"; | ||
|
There was a problem hiding this comment. you should not put colors here if the terminal does not support them (by default, Windows does not) There was a problem hiding this comment. I don't want to manage color portability here. This script is complex enough. Nobody forces anyone to use the tool. |
||
| } | ||
| } | ||
| } | ||
|
|
||
| foreach ($procs as $component => $proc) { | ||
| $procStatus = proc_close($proc); | ||
|
|
||
| foreach (array('out', 'err') as $file) { | ||
| $file = "$component/phpunit.std$file"; | ||
| $h = fopen($file, 'rb'); | ||
| while (false !== $line = fgets($h)) { | ||
| echo preg_replace_callback( | ||
| '/\033\[[0-9]++(?:;[0-9]++)++m/', | ||
| function ($m) {return str_replace(';', "m\033[", $m[0]);}, | ||
| $line | ||
| ); | ||
| } | ||
| fclose($h); | ||
| unlink($file); | ||
| } | ||
|
|
||
| if ($procStatus) { | ||
| $exit = 1; | ||
| echo "\033[41mKO\033[0m $component\n\n"; | ||
| } else { | ||
| echo "\033[32mOK\033[0m $component\n\n"; | ||
| } | ||
| } | ||
|
|
||
| } elseif (!isset($argv[1]) || 'install' !== $argv[1]) { | ||
| # Run regular phpunit in a subprocess | ||
|
|
||
| $cmd[0] = "php $PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit --colors=always"; | ||
|
|
||
| $errFile = tempnam(sys_get_temp_dir(), 'phpunit.stderr.'); | ||
| if ($proc = proc_open(implode(' ', $cmd).' 2> '.escapeshellarg($errFile), array(1 => array('pipe', 'w')), $pipes)) { | ||
| while (false !== $line = fgets($pipes[1])) { | ||
| echo $line; | ||
| } | ||
| fclose($pipes[1]); | ||
| $exit = proc_close($proc); | ||
|
|
||
| $h = fopen($errFile, 'rb'); | ||
| while (false !== $line = fgets($h)) { | ||
| echo $line; | ||
| } | ||
| fclose($h); | ||
| unlink($errFile); | ||
| } | ||
|
|
||
| if (file_exists($component = array_pop($argv))) { | ||
| if ($exit) { | ||
| echo "\033[41mKO\033[0m $component\n\n"; | ||
| } else { | ||
| echo "\033[32mOK\033[0m $component\n\n"; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| exit($exit); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -491,6 +491,10 @@ public function testRenderException() | |
|
|
||
| public function testRenderExceptionWithDoubleWidthCharacters() | ||
| { | ||
| if (!function_exists('mb_strwidth')) { | ||
|
There was a problem hiding this comment. why not using There was a problem hiding this comment. As a reminder that only mb_strwidth is required here and that this could be replaced as mb_strwidth is broken anyway, see e.g. https://github.com/nicolas-grekas/Patchwork-UTF8/blob/master/class/Patchwork/Utf8.php#L602 for a working implementation of string width on unicode terminals. |
||
| $this->markTestSkipped('The "mb_strwidth" function is not available'); | ||
| } | ||
|
|
||
| $application = $this->getMock('Symfony\Component\Console\Application', array('getTerminalWidth')); | ||
| $application->setAutoExit(false); | ||
| $application->expects($this->any()) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't it be cleaner to just have phpunit in require-dev? Or is it blocked because of it's dep on yml component?
Would also be easier for first time contributors, now that phpunit on pear, and pear itself, is dead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly not, see #13934 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would not work properly for component builds unless we add it in all components too and make the logic locating phpunit much more complex. It would make things even worse by forbidding to test components against Yaml 3.0 as PHPUnit would force using the 2.x component
The issue we want to solve here is that some optional PHPUnit feature (not used in Symfony) make it require the Yaml component 2.x and we don't want that dependencies to be able to test our Yaml component properly in any version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, clear
side:
well.. that doesn't sounds valid, if it is in require dev it will always be in one location, so you can scrap the logic involved for that and rather focus on other things, but if it is not possible this is besides the point. nothing to see here 🚶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrerom I'm talking about the logic to locate PHPunit in our CI setup, which is running the testsuite both for the fullstack repo and for each component. If it is in the require_dev section of each component, it means we have a different PHPunit location for each component