[EventDispatcher] fix memory leak in getListeners #15821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tobion
commented
Sep 17, 2015
Tobion
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -46,21 +44,23 @@ public function dispatch($eventName, Event $event = null) | |||
| $event->setDispatcher($this); | |||
| $event->setName($eventName); | |||
|
|
|||
| if (!isset($this->listeners[$eventName])) { | |||
There was a problem hiding this comment.
This doesn't bring much value and is not reliable anyway as it could also be set with an empty array by adding and removing a listener. By removing this we can also save a call to lazyLoad in the overwritten ContainerAwareEventDispatcher
Tobion
changed the title
|
LGTM 👍 |
|
Thank you @Tobion. |
fabpot
added a commit
that referenced
this pull request
Sep 22, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [EventDispatcher] fix memory leak in getListeners | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- a7b7f54 [EventDispatcher] skip one lazy loading call ec59953 [EventDispatcher] fix memory leak in a getListeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.