[Serializer] ObjectNormalizer: don't serialize static methods and props #16546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Nov 14, 2015
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #16485 |
| License | MIT |
| Doc PR | n/a |
|
Maybe should I open another PR for the PropertyAccess Component to prevent it from trying to access static methods/properties? |
| @@ -66,8 +66,9 @@ public function normalize($object, $format = null, array $context = array()) | |||
|
|
|||
| // methods | |||
| $reflClass = new \ReflectionClass($object); | |||
| foreach ($reflClass->getMethods(\ReflectionMethod::IS_PUBLIC) as $reflMethod) { | |||
| foreach ($reflClass->getMethods(\ReflectionMethod::IS_PUBLIC ) as $reflMethod) { | |||
|
CS fixed. Travis failure is not related. |
|
ping @symfony/deciders |
|
yeah thanks @dunglas to take seriously my problem! |
|
makes sense to me |
|
👍 Status: Reviewed |
|
👍 |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Nov 17, 2015
…ods and props (dunglas) This PR was squashed before being merged into the 2.7 branch (closes #16546). Discussion ---------- [Serializer] ObjectNormalizer: don't serialize static methods and props | Q | A | ------------- | --- | Bug fix? | yes | New feature? |no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16485 | License | MIT | Doc PR | n/a Commits ------- 1fab27b [Serializer] ObjectNormalizer: don't serialize static methods and props
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.