update php/object tag syntax #16952
update php/object tag syntax #16952
Conversation
the old syntax (double exclamation mark) is to represent native YAML types, a single exclamation mark represent a local tag. an E_USER_DEPRECATED error is triggered for old tags. fixes #16877
|
Actually, I would consider this a bugfix which means that the changes here (except for the deprecation trigger) should be done in 2.3. |
| @@ -477,8 +477,11 @@ private static function evaluateScalar($scalar, $references = array()) | |||
| case 0 === strpos($scalar, '! '): | |||
| return (int) self::parseScalar(substr($scalar, 2)); | |||
| case 0 === strpos($scalar, '!!php/object:'): | |||
| trigger_error('!!php/object is deprecated use !php/object instead', E_USER_DEPRECATED); | |||
| $scalar = substr($scalar, 1); | |||
There was a problem hiding this comment.
I would add a comment saying the fallthrough is intended
|
I agree with @xabbuh that we should consider the proper syntax as a bugfix. The deprecation should then be added in master only |
| @@ -477,8 +477,11 @@ private static function evaluateScalar($scalar, $references = array()) | |||
| case 0 === strpos($scalar, '! '): | |||
| return (int) self::parseScalar(substr($scalar, 2)); | |||
| case 0 === strpos($scalar, '!!php/object:'): | |||
| trigger_error('!!php/object is deprecated use !php/object instead', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
missing silencing (which makes the testsuite fail btw)
update assertions
|
Oh well, there's a difference in running the Yaml suite and running the full suite... |
|
@koenpunt Can you only add the deprecation here and create a new pull request for the bugfix based on the |
| @@ -477,8 +477,11 @@ private static function evaluateScalar($scalar, $references = array()) | |||
| case 0 === strpos($scalar, '! '): | |||
| return (int) self::parseScalar(substr($scalar, 2)); | |||
| case 0 === strpos($scalar, '!!php/object:'): | |||
| @trigger_error('!!php/object is deprecated since version 3.0 and will be removed in 4.0. Use !php/object instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
The version this will be deprecated in is 3.1 (not 3.0).
|
👌 |
[Yaml] deprecate old php/object syntax
the old syntax (double exclamation mark) is to represent native YAML
types, a single exclamation mark represent a local tag.
an E_USER_DEPRECATED error is triggered for old tags.