Fix the logout path when not using the router #17048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting.
|
I'm sending another PR for the bugfix in 2.7+ as the code is not here anymore |
|
Can we add a test for this to prevent regressions? |
|
👍 |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2015
This PR was merged into the 2.7 branch. Discussion ---------- Fix the logout path when not using the router | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17029 | License | MIT | Doc PR | n/a This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting. Similar to #17048, but in the new code location Commits ------- 542b877 Fix the logout path when not using the router
|
Thank you @stof. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 18, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Fix the logout path when not using the router | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #17029 | License | MIT | Doc PR | n/a This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting. Commits ------- 1a2567e Fix the logout path when not using the router
|
@xabbuh merged because testing is really hard currently |
This was referenced Dec 26, 2015
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting.