Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][HttpKernel] the finder is required to discover bundle commands #17057

Closed
wants to merge 2 commits into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Dec 17, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #17038
License MIT
Doc PR

@stof
Copy link
Member

stof commented Dec 17, 2015

👍

1 similar comment
@dunglas
Copy link
Member

dunglas commented Dec 17, 2015

👍

@xabbuh
Copy link
Member Author

xabbuh commented Dec 17, 2015

The failure on PHP 7 looks weird to me (Composer isn't able to find a matching package for symfony/finder).

@nicolas-grekas
Copy link
Member

@xabbuh you need to remove the finder component from require-dev, that's the issue!

@xabbuh
Copy link
Member Author

xabbuh commented Dec 18, 2015

@nicolas-grekas oh good catch, thanks, the builds should pass now

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

nicolas-grekas added a commit that referenced this pull request Dec 18, 2015
…scover bundle commands (xabbuh)

This PR was squashed before being merged into the 2.3 branch (closes #17057).

Discussion
----------

[FrameworkBundle][HttpKernel] the finder is required to discover bundle commands

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17038
| License       | MIT
| Doc PR        |

Commits
-------

17fcef5 [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands
@nicolas-grekas
Copy link
Member

Closed via e69491c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants